New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1220: Add multi-arch flag to CLI & associated validation #3689
Conversation
@bryan-cox: This pull request references HOSTEDCP-1220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test images |
/retest-required |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5259bd3
to
ab7b303
Compare
/test images |
86bcd0d
to
b75f2aa
Compare
/test images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise LGTM
Signed-off-by: Bryan Cox <brcox@redhat.com>
Signed-off-by: Bryan Cox <brcox@redhat.com>
b75f2aa
to
896297e
Compare
/lgtm |
/test e2e-kubevirt-aws-ovn |
/retest |
/test e2e-kubevirt-aws-ovn |
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202403120715.p0.g331d1a5.assembly.stream.el9 for distgit hypershift. |
What this PR does / why we need it:
Adds the multi-arch flag to the HyperShift CLI to trigger additional validation to ensure a multi-arch release image or stream was used.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1220
Checklist