Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1220: Add multi-arch flag to CLI & associated validation #3689

Merged
merged 2 commits into from Mar 12, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
Adds the multi-arch flag to the HyperShift CLI to trigger additional validation to ensure a multi-arch release image or stream was used.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1220

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@bryan-cox: This pull request references HOSTEDCP-1220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
Adds the multi-arch flag to the HyperShift CLI to trigger additional validation to ensure a multi-arch release image or stream was used.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1220

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/cli Indicates the PR includes changes for CLI labels Mar 5, 2024
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 5, 2024
@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify
/test e2e-aws

@bryan-cox
Copy link
Member Author

/retest-required

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit ab7b303
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65eb50dc56c2b600085a2170
😎 Deploy Preview https://deploy-preview-3689--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Mar 8, 2024
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1220 branch 3 times, most recently from 5259bd3 to ab7b303 Compare March 8, 2024 17:54
@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify
/test e2e-aws

@bryan-cox bryan-cox force-pushed the HOSTEDCP-1220 branch 2 times, most recently from 86bcd0d to b75f2aa Compare March 8, 2024 18:29
@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify
/test e2e-aws

Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise LGTM

cmd/cluster/aws/create_test.go Outdated Show resolved Hide resolved
Signed-off-by: Bryan Cox <brcox@redhat.com>
Signed-off-by: Bryan Cox <brcox@redhat.com>
@jparrill
Copy link
Contributor

/lgtm

@bryan-cox bryan-cox marked this pull request as ready for review March 11, 2024 13:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@openshift-ci openshift-ci bot requested review from enxebre and sjenning March 11, 2024 13:45
@bryan-cox
Copy link
Member Author

/test e2e-kubevirt-aws-ovn

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0ede7f0 and 2 for PR HEAD 896297e in total

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 331d1a5 into openshift:main Mar 12, 2024
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202403120715.p0.g331d1a5.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants