Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1467: ARO HCP - Add ability to specify subnet at nodepool level #3748

Merged
merged 2 commits into from Mar 15, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
This PR allows the subnet to be set on a NodePool basis rather than just at the Hosted Cluster level.

This PR also adds a flag to define the initial NodePool's subnet name when creating an Azure cluster, and it adds a flag when creating Azure NodePools to the HyperShift CLI.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1467

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2024

@bryan-cox: This pull request references HOSTEDCP-1467 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
This PR allows the subnet to be set on a NodePool basis rather than just at the Hosted Cluster level.

This PR also adds a flag to define the initial NodePool's subnet name when creating an Azure cluster, and it adds a flag when creating Azure NodePools to the HyperShift CLI.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1467

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit db34332
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65f2f50f407d71000844bc43
😎 Deploy Preview https://deploy-preview-3748--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-cox bryan-cox force-pushed the HOSTEDCP-1467 branch 2 times, most recently from d76bd57 to 33237dc Compare March 13, 2024 20:27
@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify

@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify

Signed-off-by: Bryan Cox <brcox@redhat.com>
Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Copy link
Member Author

/test images
/test unit
/test verify

@bryan-cox bryan-cox changed the title HOSTEDCP-1467: Add ability to specify subnet at nodepool level HOSTEDCP-1467: ARO HCP - Add ability to specify subnet at nodepool level Mar 14, 2024
@csrwng
Copy link
Contributor

csrwng commented Mar 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
@bryan-cox bryan-cox marked this pull request as ready for review March 15, 2024 00:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@bryan-cox
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 5eace16 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 5eace16 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5071706 into openshift:main Mar 15, 2024
12 of 14 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1467 branch March 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants