New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1467: ARO HCP - Add ability to specify subnet at nodepool level #3748
Conversation
@bryan-cox: This pull request references HOSTEDCP-1467 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d76bd57
to
33237dc
Compare
/test images |
db34332
to
f126edf
Compare
/test images |
Signed-off-by: Bryan Cox <brcox@redhat.com>
Signed-off-by: Bryan Cox <brcox@redhat.com>
f126edf
to
5eace16
Compare
/test images |
/lgtm |
/retest |
@bryan-cox: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5071706
into
openshift:main
What this PR does / why we need it:
This PR allows the subnet to be set on a NodePool basis rather than just at the Hosted Cluster level.
This PR also adds a flag to define the initial NodePool's subnet name when creating an Azure cluster, and it adds a flag when creating Azure NodePools to the HyperShift CLI.
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1467
Checklist