Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-31064: ibmcloud KMS: remove breaking image check and enable KMS v2 support #3774

Merged
merged 1 commit into from Mar 27, 2024
Merged

[release-4.15] OCPBUGS-31064: ibmcloud KMS: remove breaking image check and enable KMS v2 support #3774

merged 1 commit into from Mar 27, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3760

/assign rtheis

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2024
Merged
4 tasks
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30968 has been cloned as Jira Issue OCPBUGS-31064. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-31064: ibmcloud KMS: remove breaking image check and enable KMS v2 support

In response to this:

This is an automated cherry-pick of #3760

/assign rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-30968: ibmcloud KMS: remove breaking image check and enable KMS v2 support [release-4.15] OCPBUGS-31064: ibmcloud KMS: remove breaking image check and enable KMS v2 support Mar 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31064, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30968 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3760

/assign rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 19, 2024
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Mar 19, 2024
rtheis
rtheis approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@riendeau
Copy link
Contributor

/assign @csrwng

@rtheis
Copy link
Contributor

rtheis commented Mar 22, 2024

/retest

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented Mar 22, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 22, 2024

/override "Red Hat Konflux"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@rtheis: rtheis unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override "Red Hat Konflux"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@riendeau
Copy link
Contributor

/retest

@csrwng
Copy link
Contributor

csrwng commented Mar 25, 2024

/jira refresh
/approve

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2024
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-31064, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30968 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30968 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng
Copy link
Contributor

csrwng commented Mar 25, 2024

/override "Red Hat Konflux"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, openshift-cherrypick-robot, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux

In response to this:

/override "Red Hat Konflux"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f806002 and 2 for PR HEAD 68e09ae in total

@rtheis
Copy link
Contributor

rtheis commented Mar 25, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3725803 and 1 for PR HEAD 68e09ae in total

@rtheis
Copy link
Contributor

rtheis commented Mar 26, 2024

/retest

3 similar comments
@rtheis
Copy link
Contributor

rtheis commented Mar 26, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 26, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 26, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7870fb5 and 0 for PR HEAD 68e09ae in total

@openshift-ci-robot
Copy link

/hold

Revision 68e09ae was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

4 similar comments
@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

CI must be busted.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4a173bf and 2 for PR HEAD 68e09ae in total

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3e3729d into openshift:release-4.15 Mar 27, 2024
8 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31064: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31064 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3760

/assign rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-28-062014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@csrwng csrwng

@rtheis rtheis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @riendeau @rtheis @csrwng @openshift-merge-robot