Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1478: Request serving node scheduler that uses HC size label #3776

Merged
merged 1 commit into from Mar 26, 2024

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Mar 19, 2024

What this PR does / why we need it:
Introduces a new scheduler that is only enabled if cluster size tagging is enabled. It takes into consideration the size label of a particular hosted cluster to select nodes where the cluster's request serving pods are scheduled and applies settings configured in the cluster sizing configuration to the hosted cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1478

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2024

@csrwng: This pull request references HOSTEDCP-1478 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Introduces a new scheduler that is only enabled if cluster size tagging is enabled. It takes into consideration the size label of a particular hosted cluster to select nodes where the cluster's request serving pods are scheduled and applies settings configured in the cluster sizing configuration to the hosted cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1478

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2024
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Mar 19, 2024
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024

@csrwng: This pull request references HOSTEDCP-1478 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Introduces a new scheduler that is only enabled if cluster size tagging is enabled. It takes into consideration the size label of a particular hosted cluster to select nodes where the cluster's request serving pods are scheduled and applies settings configured in the cluster sizing configuration to the hosted cluster.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1478

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng
Copy link
Contributor Author

csrwng commented Mar 22, 2024

@sjenning @muraee thx! comments addressed

@muraee
Copy link
Contributor

muraee commented Mar 22, 2024

lgtm

@csrwng csrwng force-pushed the hc_autosize_scheduler branch 3 times, most recently from 5c74045 to 721693c Compare March 26, 2024 04:08
Introduces a new scheduler that is only enabled if cluster size tagging
is enabled. It takes into consideration the size label of a
particular hosted cluster to select nodes where the cluster's request
serving pods are scheduled and applies settings configured in the cluster
sizing configuration to the hosted cluster.
@muraee
Copy link
Contributor

muraee commented Mar 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@csrwng
Copy link
Contributor Author

csrwng commented Mar 26, 2024

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks d326ff4 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks d326ff4 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4f29b99 into openshift:main Mar 26, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants