Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] NO-JIRA: Remove unused ref to hostnetwork in cpo role #3796

Merged
merged 1 commit into from Mar 28, 2024
Merged

[release-4.15] NO-JIRA: Remove unused ref to hostnetwork in cpo role #3796

merged 1 commit into from Mar 28, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3789

/assign rtheis

@jmcmeek
Remove unused ref to hostnetwork in cpo role
2ace4c6 
The control-plane-operator Role has a rule to allow use of the hostnetwork
SCC, but the control-plane-operator actually runs under the
restricted-v2 SCC.

This change removes the unused rule.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 22, 2024
Merged
4 tasks
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Mar 22, 2024
@rtheis
Copy link
Contributor

rtheis commented Mar 22, 2024

/retest

rtheis
rtheis approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@Patryk-Stefanski
Copy link
Contributor

/approve

1 similar comment
@bryan-cox
Copy link
Member

/approve

@bryan-cox
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, openshift-cherrypick-robot, Patryk-Stefanski, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4a173bf and 2 for PR HEAD 2ace4c6 in total

@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented Mar 27, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3e3729d and 1 for PR HEAD 2ace4c6 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 760ca74 into openshift:release-4.15 Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@rtheis rtheis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @rtheis @Patryk-Stefanski @bryan-cox @openshift-ci-robot @jmcmeek