NO-JIRA: Fix docs commands related to Azure ephemeral OS disks #3809
Conversation
openshift-ci
bot
added
do-not-merge/needs-area
do-not-merge/hold
openshift-ci
bot
added
area/documentation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fxierh
changed the title
|
@fxierh: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cc @bryan-cox @Patryk-Stefanski Could you please take a look ? Thanks. |
|
/retest |
|
Konflux failed but the failure (which seems to be caused by a Go version that's too low) is kinda unrelated to this PR. Wondering if we could override it. |
|
Yeah I see it failing with |
|
Yeah let's wait until we know RHTAP is working again. They may want to use this PR as an example of what's broke. |
fxierh
force-pushed
the
fix-ephemeral-os-disk-doc
branch
from
9b5dee3
to
69d50f2
Compare
|
Rebased. |
|
Konflux passed. This one is ready for review now. |
| @@ -111,7 +111,7 @@ To enable the ephemeral OS disk option on the Azure VMs in your HostedCluster, s | |||
| You may need to adjust the disk storage account type; to adjust the disk storage account type, | |||
| use the `disk-storage-account-type` flag as shown in the example below. | |||
|
|
|||
| You may need to adjust the disk size depending on the instance type used; to adjust the disk size, use the | |||
| The OS disk size defaults to 120GB. You may need to adjust the disk size depending on the instance type used; to adjust the disk size, use the | |||
There was a problem hiding this comment.
This is not true. It defaults to 30Gb.
There was a problem hiding this comment.
The required disk size is based on the instance type you use. Maybe you could rewrite this to say The default size disk size of the instance type, Standard_DS4_v2, is 120GB. You should update the examples to show the updated disk size flag setting this.
There was a problem hiding this comment.
Reverted this phrase to its original state.
Signed-off-by: Feilian Xie <fxie@redhat.com>
fxierh
force-pushed
the
fix-ephemeral-os-disk-doc
branch
from
69d50f2
to
620c094
Compare
|
@fxierh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, fxierh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202403281444.p0.gd140126.assembly.stream.el9 for distgit hypershift. |
Encountered this error when following commands in the docs (was testing HOSTEDCP-1373):
"OS disk of Ephemeral VM with size greater than 86 GB is not allowed for VM size Standard_DS2_v2 when the DiffDiskPlacement is CacheDisk. Please refer to https://aka.ms/Ephemeral for more details."Some YAMLs:
AzureMachine.txt
np.txt
Root case:
A Standard_DS2_v2 VM allows for 86GB of temp storage but OS disk size defaults to 120GB.
See https://learn.microsoft.com/en-us/azure/virtual-machines/dv2-dsv2-series#dsv2-series.