Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] HOSTEDCP-1322: NodeUpgradeType defaulted by provider #3822

Merged
merged 1 commit into from Apr 2, 2024
Merged

[release-4.14] HOSTEDCP-1322: NodeUpgradeType defaulted by provider #3822

merged 1 commit into from Apr 2, 2024

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Apr 1, 2024

Manual backport from #3273

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1322

@jparrill
HOSTEDCP-1322: NodeUpgradeType defaulted by provider
aa0d690 
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@jparrill: This pull request references HOSTEDCP-1322 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to this:

Manual backport from #3273

Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1322

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Apr 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2024 •
edited by openshift-ci bot

/jira cherrypick HOSTEDCP-1322

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@jparrill: Ignoring requests to cherry-pick non-bug issues: HOSTEDCP-1322

In response to this:

/jira cherrypick HOSTEDCP-1322

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jparrill jparrill changed the title HOSTEDCP-1322: NodeUpgradeType defaulted by provider [release-4.14] HOSTEDCP-1322: NodeUpgradeType defaulted by provider Apr 1, 2024
@sjenning
Copy link
Contributor

sjenning commented Apr 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8de7bff and 2 for PR HEAD aa0d690 in total

@LiangquanLi930
Copy link
Member

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 2, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 741a78d into openshift:release-4.14 Apr 2, 2024
8 of 10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.14.0-202404020544.p0.g741a78d.assembly.stream.el8 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jparrill @openshift-ci-robot @sjenning @LiangquanLi930 @openshift-bot