Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: docs: fixing wrong key name #3833

Merged
merged 2 commits into from Apr 5, 2024

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Apr 3, 2024

What this PR does / why we need it:
The key name in the ConfigMap is tuning and not tuned.
https://github.com/openshift/hypershift/blob/main/hypershift-operator/controllers/nodepool/nodepool_controller.go#L101

Which issue(s) this PR fixes
Fixes #
N/A

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link

@Tal-or: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
The key name in the ConfigMap is "tuning" and not "tuned".

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Apr 3, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 4, 2024

/retest

1 similar comment
@jparrill
Copy link
Contributor

jparrill commented Apr 4, 2024

/retest

@jparrill
Copy link
Contributor

jparrill commented Apr 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@sjenning
Copy link
Contributor

sjenning commented Apr 4, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@sjenning
Copy link
Contributor

sjenning commented Apr 4, 2024

please run make update and commit the changes to generated files

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b63674f and 2 for PR HEAD 3b1df20 in total

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation and removed lgtm Indicates that a PR is ready to be merged. labels Apr 4, 2024
The key name in the ConfigMap is tuning and not tuned.
https://github.com/openshift/hypershift/blob/main/hypershift-operator/controllers/nodepool/nodepool_controller.go#L101

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit fe1d906
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/660ee779be52370008362360
😎 Deploy Preview https://deploy-preview-3833--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 4, 2024

please run make update and commit the changes to generated files

Sorry I was not aware of this make target. Done

@jparrill
Copy link
Contributor

jparrill commented Apr 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2fbe4a4 and 2 for PR HEAD 5277916 in total

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

@Tal-or: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 5277916 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 5277916 link false /test e2e-ibmcloud-iks
ci/prow/e2e-kubevirt-azure-ovn 3b1df20 link false /test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ed406e8 into openshift:main Apr 5, 2024
12 of 14 checks passed
@Tal-or Tal-or deleted the doc_fix_tuning_config branch April 5, 2024 14:24
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202404051041.p0.ged406e8.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants