New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: docs: fixing wrong key name #3833
NO-JIRA: docs: fixing wrong key name #3833
Conversation
@Tal-or: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cb18220
to
3b1df20
Compare
/retest |
1 similar comment
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please run |
3b1df20
to
fe1d906
Compare
The key name in the ConfigMap is tuning and not tuned. https://github.com/openshift/hypershift/blob/main/hypershift-operator/controllers/nodepool/nodepool_controller.go#L101 Signed-off-by: Talor Itzhak <titzhak@redhat.com>
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
fe1d906
to
5277916
Compare
Sorry I was not aware of this make target. Done |
/lgtm |
@Tal-or: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ed406e8
into
openshift:main
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.16.0-202404051041.p0.ged406e8.assembly.stream.el9 for distgit hypershift. |
What this PR does / why we need it:
The key name in the ConfigMap is
tuning
and nottuned
.https://github.com/openshift/hypershift/blob/main/hypershift-operator/controllers/nodepool/nodepool_controller.go#L101
Which issue(s) this PR fixes
Fixes #
N/A