Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Update expected condition to false for ValidAzureKmsConfig s… #3837

Merged
merged 1 commit into from Apr 4, 2024
Merged

NO-JIRA: Update expected condition to false for ValidAzureKmsConfig s… #3837

merged 1 commit into from Apr 4, 2024

Conversation

Patryk-Stefanski
Copy link
Contributor

Update expected condition to false for ValidAzureKmsConfig to reflect !3804

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2024
@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request explicitly references no jira issue.

In response to this:

Update expected condition to false for ValidAzureKmsConfig to reflect !3804

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre April 4, 2024 12:46
@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Apr 4, 2024
@muraee
Copy link
Contributor

muraee commented Apr 4, 2024

nice catch! that change was not actually intended.
Please revert that change instead and set the condition to ConditionUnknown again when azure kms is not configured.

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 4, 2024
@Patryk-Stefanski Patryk-Stefanski force-pushed the UpdateExpectedConditionForValidAzureKMSConfig branch from 1feb9b0 to c46e43a Compare April 4, 2024 13:16
@Patryk-Stefanski Patryk-Stefanski force-pushed the UpdateExpectedConditionForValidAzureKMSConfig branch from c46e43a to 5e0eb98 Compare April 4, 2024 13:32
@muraee
Copy link
Contributor

muraee commented Apr 4, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-kubevirt-azure-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

@Patryk-Stefanski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-azure-ovn 5e0eb98 link false /test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2fbe4a4 into openshift:main Apr 4, 2024
12 of 13 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202404041943.p0.g2fbe4a4.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@muraee muraee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Patryk-Stefanski @openshift-ci-robot @muraee @openshift-bot