OCPBUGS-14383: disable autoscaler when no nodepool requires it

[sjenning]

Creates a new DisableClusterAutoscalerAnnotation set on the HostedControlPlane by the hypershift-operator when none of the NodePools for a particular HostedCluster have spec.autoScaling set. When this annotation is set on the HCP, the CPO sets replicas on the cluster-autoscaler Deployment to 0.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	dc9b9e6
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/66140734ef56f70008d7fbc8
😎 Deploy Preview	https://deploy-preview-3846--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[openshift-ci-robot]

@sjenning: This pull request references Jira Issue OCPBUGS-14383, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Creates a new DisableClusterAutoscalerAnnotation set on the HostedControlPlane by the hypershift-operator when none of the NodePools for a particular HostedCluster have spec.autoScaling set. When this annotation is set on the HCP, the CPO sets replicas on the cluster-autoscaler Deployment to 0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[muraee]

/lgtm

[sjenning]

/retest

[enxebre]

Thanks, this is good behavioural fix! fwiw instead of adding a new annotation we could let isAutoscalingNeeded within reconcileHostedControlPlane to set hcp.Spec.Autoscaling = hcluster.Spec.Autoscaling or not hcp.Spec.Autoscaling = nil, and let that be what dictates the deployment.spec.replicas. This might not be trivial though since hcp.spec.autoscaling is not a pointer. I'm fine with the annotation too.

[sjenning]

/retest

[sjenning]

/retest

[sjenning]

/test e2e-aws

[sjenning]

/test e2e-aws

[openshift-bot]

/retest-required

Remaining retests: 0 against base HEAD fabd790 and 2 for PR HEAD dc9b9e6 in total

[sjenning]

/test e2e-aws

[sjenning]

/test e2e-aws

[sjenning]

/test e2e-aws

[sjenning]

/test e2e-aws

[sjenning]

/override ci/prow/e2e-aws

[openshift-ci]

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

@sjenning: Jira Issue OCPBUGS-14383: All pull requests linked via external trackers have merged:

• openshift/hypershift#3846

Jira Issue OCPBUGS-14383 has been moved to the MODIFIED state.

In response to this:

Creates a new DisableClusterAutoscalerAnnotation set on the HostedControlPlane by the hypershift-operator when none of the NodePools for a particular HostedCluster have spec.autoScaling set. When this annotation is set on the HCP, the CPO sets replicas on the cluster-autoscaler Deployment to 0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sjenning]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@sjenning: #3846 failed to apply on top of branch "release-4.15":

Applying: disable autoscaler when no nodepool require it
Using index info to reconstruct a base tree...
M	api/hypershift/v1beta1/hostedcluster_types.go
M	control-plane-operator/controllers/hostedcontrolplane/autoscaler/reconcile.go
M	hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
M	hypershift-operator/controllers/hostedcluster/hostedcluster_controller_test.go
A	vendor/github.com/openshift/hypershift/api/hypershift/v1beta1/hostedcluster_types.go
Falling back to patching base and 3-way merge...
Auto-merging hypershift-operator/controllers/hostedcluster/hostedcluster_controller_test.go
Auto-merging hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
CONFLICT (content): Merge conflict in hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/autoscaler/reconcile.go
Auto-merging api/hypershift/v1beta1/hostedcluster_types.go
CONFLICT (content): Merge conflict in api/hypershift/v1beta1/hostedcluster_types.go
Auto-merging api/hypershift/v1alpha1/hostedcluster_types.go
CONFLICT (content): Merge conflict in api/hypershift/v1alpha1/hostedcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable autoscaler when no nodepool require it
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-29-154406