NO-JIRA: [e2e test framework] Add a flag to add an annotation to HostedCluster

[orenc1]

What this PR does / why we need it:
This addition will allow us to insert a custom annotation needed for the e2e test suite for the HostedCluster.
In particular, specify the management platform type in case of kubevirt external infra testing.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	082e2e0
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6615955457ded400078ce657
😎 Deploy Preview	https://deploy-preview-3854--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[davidvossel]

I'd suggest making the annotations repeatable. That way we can add more than one annotation at a time. That will probably help us out in the future.

you can achieve this using a custom var with the flags package. i tested this out. here's an example.

package main

import (
        "flag" 
        "fmt"
        "strings"
)

type stringMapVar map[string]string

func (s *stringMapVar) String() string {
        if *s == nil {
                return ""
        }
        return fmt.Sprintf("%v", *s)
}

func (s *stringMapVar) Set(value string) error {
        split := strings.Split(value, "=")
        if len(split) != 2 {
                return fmt.Errorf("invalid argument: %s", value)
        }
        if *s == nil {
                *s = stringMapVar(map[string]string{})
        }
        map[string]string(*s)[split[0]] = split[1]
        return nil
}

var annotations stringMapVar

func main() {

        flag.Var(&annotations, "annotations", "")
        flag.Parse()

        if annotations != nil {
                fmt.Printf("%s\n", annotations.String())
        }
}

[orenc1]

done, thanks.
e2e.annotations can be specified multiple times and the annotations are aggregated.

[davidvossel]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[orenc1]

/test e2e-aws

[rcerven]

/retest

[openshift-ci-robot]

@orenc1: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
This addition will allow us to insert a custom annotation needed for the e2e test suite for the HostedCluster.
In particular, specify the management platform type in case of kubevirt external infra testing.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[orenc1]

/retest

[openshift-ci]

@orenc1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[orenc1]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@orenc1: #3854 failed to apply on top of branch "release-4.15":

Applying: Add a flag to add an annotation to HostedCluster
Using index info to reconstruct a base tree...
M	test/e2e/e2e_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/e2e_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add a flag to add an annotation to HostedCluster
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.