OCPBUGS-29494: Fix disconnected metadata inspection

[jparrill]

Now the Hypershift operator does not ignore RegistryOverrides and the metadata inspection works as expected

Which issue(s) this PR fixes:
Fixes #OCPBUGS-29494

• PR Tested in a Baremetal/Dual Stack/Disconnected environment with this custom image: quay.io/jparrill/hypershift:OCPBUGS-29494v7

[openshift-bot]

@jparrill: This pull request references Jira Issue OCPBUGS-29494, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Now the Hypershift operator does not ignore RegistryOverrides and the metadata inspection works as expected

Which issue(s) this PR fixes:
Fixes #OCPBUGS-29494

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	0d4e3c3
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6616efe326e2ab0008e71a96
😎 Deploy Preview	https://deploy-preview-3860--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jparrill]

/jira refresh

[openshift-bot]

@jparrill: This pull request references Jira Issue OCPBUGS-29494, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

@jparrill: This pull request references Jira Issue OCPBUGS-29494, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

Now the Hypershift operator does not ignore RegistryOverrides and the metadata inspection works as expected

Which issue(s) this PR fixes:
Fixes #OCPBUGS-29494

• PR Tested in a Baremetal/Dual Stack/Disconnected environment with this custom image: quay.io/jparrill/hypershift:OCPBUGS-29494v7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jparrill]

/test e2e-aws

[bryan-cox]

/test e2e-aws

[openshift-ci]

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[bryan-cox]

/lgtm

[jparrill]

/retest

[openshift-ci-robot]

@jparrill: Jira Issue OCPBUGS-29494: All pull requests linked via external trackers have merged:

• openshift/hypershift#3860

Jira Issue OCPBUGS-29494 has been moved to the MODIFIED state.

In response to this:

Now the Hypershift operator does not ignore RegistryOverrides and the metadata inspection works as expected

Which issue(s) this PR fixes:
Fixes #OCPBUGS-29494

• PR Tested in a Baremetal/Dual Stack/Disconnected environment with this custom image: quay.io/jparrill/hypershift:OCPBUGS-29494v7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jparrill]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@jparrill: #3860 failed to apply on top of branch "release-4.15":

Applying: OCPBUGS-29494: Fix disconnected metadata inspection
Using index info to reconstruct a base tree...
M	support/util/imagemetadata.go
M	support/util/imagemetadata_test.go
Falling back to patching base and 3-way merge...
Auto-merging support/util/imagemetadata_test.go
CONFLICT (content): Merge conflict in support/util/imagemetadata_test.go
Auto-merging support/util/imagemetadata.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-29494: Fix disconnected metadata inspection
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448