-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1526: [release-4.14] Support additional node selectors for request serving nodes #3898
HOSTEDCP-1526: [release-4.14] Support additional node selectors for request serving nodes #3898
Conversation
Adds annotation to specify additional node selectors. This is needed for request serving nodes to request the corresponding size label.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@csrwng: This pull request references HOSTEDCP-1526 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/area control-plane-operator |
/test e2e-kubevirt-aws-ovn |
I'm facing the same issue with kubevirt tests in other 4.14 release backports. @davidvossel Is this expected to fail? |
/lgtm |
/override "ci/prow/e2e-kubevirt-aws-ovn" |
@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@csrwng: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
83a47ba
into
openshift:release-4.14
What this PR does / why we need it:
Adds annotation to specify additional node selectors. This is needed for request serving nodes to request the corresponding size label.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #HOSTEDCP-1526
Checklist