Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1526: [release-4.14] Support additional node selectors for request serving nodes #3898

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Apr 16, 2024

What this PR does / why we need it:
Adds annotation to specify additional node selectors. This is needed for request serving nodes to request the corresponding size label.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1526

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

Adds annotation to specify additional node selectors. This is needed for
request serving nodes to request the corresponding size label.
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Apr 16, 2024
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@csrwng csrwng changed the title [release-4.14] Support additional node selectors for request serving nodes HOSTEDCP-1526: [release-4.14] Support additional node selectors for request serving nodes Apr 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2024

@csrwng: This pull request references HOSTEDCP-1526 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Adds annotation to specify additional node selectors. This is needed for request serving nodes to request the corresponding size label.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@csrwng
Copy link
Contributor Author

csrwng commented Apr 16, 2024

/area control-plane-operator

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Apr 16, 2024
@jparrill
Copy link
Contributor

/test e2e-kubevirt-aws-ovn

@jparrill
Copy link
Contributor

I'm facing the same issue with kubevirt tests in other 4.14 release backports. @davidvossel Is this expected to fail?

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 96b62a5 and 2 for PR HEAD c7bc57b in total

@csrwng
Copy link
Contributor Author

csrwng commented Apr 17, 2024

/override "ci/prow/e2e-kubevirt-aws-ovn"

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override "ci/prow/e2e-kubevirt-aws-ovn"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks c7bc57b link false /test e2e-ibmcloud-roks
ci/prow/e2e-kubevirt-aws-ovn c7bc57b link true /test e2e-kubevirt-aws-ovn
ci/prow/e2e-ibmcloud-iks c7bc57b link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 83a47ba into openshift:release-4.14 Apr 17, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants