Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1566: Bump CAPI dependencies #4011

Merged
merged 1 commit into from
May 10, 2024
Merged

HOSTEDCP-1566: Bump CAPI dependencies #4011

merged 1 commit into from
May 10, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1566

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot

@bryan-cox: This pull request references HOSTEDCP-1566 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1566

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
bryan-cox
bryan-cox commented May 9, 2024
View reviewed changes
go.mod
replace (
github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.18.0
github.com/prometheus/common => github.com/prometheus/common v0.47.0
)
Copy link
Member Author

@bryan-cox bryan-cox May 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure what the error is exactly 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

% make build
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/hypershift-operator ./hypershift-operator
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/control-plane-operator ./control-plane-operator
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/control-plane-pki-operator ./control-plane-pki-operator
# github.com/prometheus/client_golang/prometheus/testutil/promlint
vendor/github.com/prometheus/client_golang/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.NewFormat
make: *** [control-plane-pki-operator] Error 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/prometheus/client_golang/releases/tag/v1.19.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also pinned Prometheus deps in CAPA https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/go.mod#L7-L10 because component-base still using old versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Steve was discussing this with me as well on Slack.

@bryan-cox
Copy link
Member Author

/test all

@bryan-cox
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 9, 2024
@bryan-cox
Copy link
Member Author

/test e2e-aws

@bryan-cox
Bump CAPI dependencies
b0a6b0a 
Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Copy link
Member Author

/test all

@netlify Netlify
Copy link

netlify bot commented May 10, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit b0a6b0a
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/663e2170a77c2e000876c3b5
😎 Deploy Preview https://deploy-preview-4011--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@bryan-cox bryan-cox marked this pull request as ready for review May 10, 2024 15:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2ec8cfb into openshift:main May 10, 2024
13 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202405102145.p0.g2ec8cfb.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muraee muraee muraee left review comments

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryan-cox @openshift-ci-robot @stevekuznetsov @openshift-bot @muraee