OCPBUGS-34580: Add TrustedBundles to OAS container #4106

jparrill · 2024-05-29T09:06:36Z

Manual cherry pick from #4087

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

openshift-ci-robot · 2024-05-29T09:06:42Z

@jparrill: This pull request references Jira Issue OCPBUGS-31446, which is invalid:

expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.17.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-31446 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick from #4087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-05-29T09:07:24Z

/approve

openshift-ci · 2024-05-29T09:08:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jparrill · 2024-05-29T09:09:05Z

/jira cherrypick OCPBUGS-31446

openshift-ci-robot · 2024-05-29T09:09:13Z

@jparrill: Jira Issue OCPBUGS-31446 has been cloned as Jira Issue OCPBUGS-34579. Will retitle bug to link to clone.
/retitle OCPBUGS-34579: OCPBUGS-31446: Add TrustedBundles to OAS container

In response to this:

/jira cherrypick OCPBUGS-31446

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-29T09:09:23Z

@jparrill: This pull request references Jira Issue OCPBUGS-34579, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-31446 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-31446 to target a version in 4.16.0, but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick from #4087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-05-29T09:10:05Z

/jira cherrypick OCPBUGS-34390

openshift-ci-robot · 2024-05-29T09:10:12Z

@jparrill: Jira Issue OCPBUGS-34390 has been cloned as Jira Issue OCPBUGS-34580. Will retitle bug to link to clone.
/retitle OCPBUGS-34580: OCPBUGS-34579: Add TrustedBundles to OAS container

In response to this:

/jira cherrypick OCPBUGS-34390

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-29T09:10:24Z

@jparrill: This pull request references Jira Issue OCPBUGS-34580, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-34390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick from #4087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-05-29T09:11:56Z

/jira refresh

openshift-ci-robot · 2024-05-29T09:11:59Z

@jparrill: This pull request references Jira Issue OCPBUGS-34580, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-34390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-05-29T09:13:03Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2024-05-29T09:13:05Z

@jparrill: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

enxebre · 2024-05-29T09:13:36Z

/lgtm

jparrill · 2024-05-29T09:43:14Z

/retest

jparrill · 2024-05-30T10:41:17Z

/retest

jparrill · 2024-06-03T08:13:15Z

/jira refresh
/retest-required

openshift-ci-robot · 2024-06-03T08:13:20Z

@jparrill: This pull request references Jira Issue OCPBUGS-34580, which is invalid:

expected dependent Jira Issue OCPBUGS-34390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-06-04T21:57:14Z

/retest

jparrill · 2024-06-05T10:02:30Z

/retest

jparrill · 2024-06-05T10:08:23Z

/jira refresh

openshift-ci-robot · 2024-06-05T10:08:27Z

@jparrill: This pull request references Jira Issue OCPBUGS-34580, which is invalid:

expected dependent Jira Issue OCPBUGS-34390 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

LiangquanLi930 · 2024-06-11T14:58:37Z

/jira refresh

openshift-ci-robot · 2024-06-11T14:58:45Z

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-34580, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-34390 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-34390 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-06-11T15:33:33Z

/retest

openshift-ci-robot · 2024-06-11T16:01:59Z

/retest-required

Remaining retests: 0 against base HEAD c1efc75 and 2 for PR HEAD 8196a56 in total

LiangquanLi930 · 2024-06-12T02:48:16Z

/test unit

openshift-ci-robot · 2024-06-12T17:21:47Z

/retest-required

Remaining retests: 0 against base HEAD 48b0be7 and 1 for PR HEAD 8196a56 in total

jparrill · 2024-06-13T07:58:55Z

/test unit

openshift-ci · 2024-06-13T08:30:45Z

@jparrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	`8196a56`	link	true	`/test unit`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

enxebre · 2024-06-13T13:52:51Z

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment_test.go

+)
+
+// Ensure certain deployment fields do not get set
+func TestReconcileOpenshiftAPIServerDeploymentNoChanges(t *testing.T) {


please follow convention for naming TestFuncName, i.e. TestReconcileDeployment()
then no changes should be a test case.

The tests is already in that way in main, I didn't created this. The new one I've included in the PR is TestReconcileOpenshiftAPIServerDeploymentTrustBundle the other was in the file already and I though that was ok, to keep it in the backport.

enxebre · 2024-06-13T13:54:41Z

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment_test.go

+func TestReconcileOpenshiftAPIServerDeploymentNoChanges(t *testing.T) {
+
+	imageName := "oapiImage"
+	// Setup expected values that are universal


what is this comment for?

inherited, not needed.

enxebre · 2024-06-13T13:55:01Z

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment_test.go

+	imageName := "oapiImage"
+	// Setup expected values that are universal
+
+	// Setup hypershift hosted control plane.


do we need this comment?

no comments needed in fact, all of them come from main.

enxebre · 2024-06-13T13:55:17Z

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment_test.go

+		additionalTrustBundle *corev1.LocalObjectReference
+		clusterConf           *hyperv1.ClusterConfiguration
+	}{
+		// empty deployment config


can we have a Name field with the test case name?

enxebre · 2024-06-13T13:55:52Z

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment_test.go

+		g := NewGomegaWithT(t)
+		expectedTermGraceSeconds := oapiDeployment.Spec.Template.Spec.TerminationGracePeriodSeconds
+		oapiDeployment.Spec.MinReadySeconds = 60
+		expectedMinReadySeconds := oapiDeployment.Spec.MinReadySeconds


it seems you are carrying oapiDeployment over all test cases loop which would let each test have side effects on each other.

jparrill · 2024-06-13T14:47:21Z

Sending a new PR to avoid conflicts on rebase #4211
/close

jparrill · 2024-06-24T08:00:15Z

/jira refresh

openshift-ci-robot · 2024-06-24T08:00:21Z

@jparrill: This pull request references Jira Issue OCPBUGS-34580, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

OCPBUGS-31446: Add TrustedBundles to OAS container

8196a56

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 29, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 29, 2024

openshift-ci bot added the do-not-merge/needs-area label May 29, 2024

openshift-ci bot requested review from csrwng and enxebre May 29, 2024 09:08

openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 29, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024

openshift-ci bot changed the title ~~OCPBUGS-31446: Add TrustedBundles to OAS container~~ OCPBUGS-34579: OCPBUGS-31446: Add TrustedBundles to OAS container May 29, 2024

jparrill changed the title ~~OCPBUGS-34579: OCPBUGS-31446: Add TrustedBundles to OAS container~~ OCPBUGS-34579: Add TrustedBundles to OAS container May 29, 2024

openshift-ci bot changed the title ~~OCPBUGS-34579: Add TrustedBundles to OAS container~~ OCPBUGS-34580: OCPBUGS-34579: Add TrustedBundles to OAS container May 29, 2024

openshift-ci bot assigned enxebre May 29, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2024

openshift-ci bot requested a review from LiangquanLi930 June 11, 2024 14:58

enxebre reviewed Jun 13, 2024

View reviewed changes

openshift-ci bot closed this Jun 13, 2024

openshift-ci-robot mentioned this pull request Jun 24, 2024

OCPBUGS-34579: Add TrustedBundles to OAS container #4211

Merged

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 24, 2024

OCPBUGS-34580: Add TrustedBundles to OAS container #4106

OCPBUGS-34580: Add TrustedBundles to OAS container #4106

Conversation

jparrill commented May 29, 2024

openshift-ci-robot commented May 29, 2024

jparrill commented May 29, 2024

openshift-ci bot commented May 29, 2024

jparrill commented May 29, 2024

openshift-ci-robot commented May 29, 2024

openshift-ci-robot commented May 29, 2024

jparrill commented May 29, 2024

openshift-ci-robot commented May 29, 2024

openshift-ci-robot commented May 29, 2024

jparrill commented May 29, 2024

openshift-ci-robot commented May 29, 2024

jparrill commented May 29, 2024

openshift-cherrypick-robot commented May 29, 2024

enxebre commented May 29, 2024

jparrill commented May 29, 2024

jparrill commented May 30, 2024

jparrill commented Jun 3, 2024

openshift-ci-robot commented Jun 3, 2024

jparrill commented Jun 4, 2024

jparrill commented Jun 5, 2024

jparrill commented Jun 5, 2024

openshift-ci-robot commented Jun 5, 2024

LiangquanLi930 commented Jun 11, 2024

openshift-ci-robot commented Jun 11, 2024

jparrill commented Jun 11, 2024

openshift-ci-robot commented Jun 11, 2024

LiangquanLi930 commented Jun 12, 2024

openshift-ci-robot commented Jun 12, 2024

jparrill commented Jun 13, 2024

openshift-ci bot commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jparrill commented Jun 13, 2024

jparrill commented Jun 24, 2024

openshift-ci-robot commented Jun 24, 2024