Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTIARCH-3204: Port operator to work with Hypershift #13

Closed
wants to merge 2 commits into from
Closed

MULTIARCH-3204: Port operator to work with Hypershift #13

wants to merge 2 commits into from

Conversation

dharaneeshvrd
Copy link
Member

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharaneeshvrd
Once this PR has been reviewed and has the lgtm label, please assign madhan-swe for approval by writing /assign @madhan-swe in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member

I prefer adding someone to review from storage team

/cc @jsafrane @gnufied

@dharaneeshvrd dharaneeshvrd changed the title Port operator to work with Hypershift MULTIARCH-3204 Port operator to work with Hypershift Jan 27, 2023
@dharaneeshvrd dharaneeshvrd changed the title MULTIARCH-3204 Port operator to work with Hypershift MULTIARCH-3204: Port operator to work with Hypershift Jan 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2023 •
edited by openshift-ci bot

@dharaneeshvrd: This pull request references MULTIARCH-3204 which is a valid jira issue.

In response to this:

Fixes https://issues.redhat.com/browse/MULTIARCH-3204

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

@dharaneeshvrd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dharaneeshvrd
Copy link
Member Author

@gnufied @jsafrane Could you please review this PR when you get a chance?

gnufied
gnufied reviewed Feb 23, 2023
View reviewed changes
.gitignore
.kube
/kubeconfig
.dockerignore
.docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things should go into your global ~/.gitignore and only project specific gitingore should be added here.

pkg/operator/starter.go
@@ -28,133 +39,377 @@ const (
defaultNamespace = "openshift-cluster-csi-drivers"
operatorName = "ibm-powervs-block-csi-driver-operator"
operandName = "ibm-powervs-block-csi-driver"
secretName = "ibm-powervs-block-cloud-credentials"
secretName = "ibm-powervs-cloud-credentials"
trustedCAConfigMap = "ibm-powervs-block-csi-driver-trusted-ca-bundle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this secret name changed?

pkg/operator/starter.go
return nil
}

deployment.Spec.Template.Spec.PriorityClassName = hypershiftPriorityClass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do same thing as openshift/aws-ebs-csi-driver-operator#186 ?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 24, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@Madhan-SWE Madhan-SWE Awaiting requested review from Madhan-SWE

@mkumatag mkumatag Awaiting requested review from mkumatag

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dharaneeshvrd @mkumatag @openshift-ci-robot @openshift-bot @openshift-merge-robot @gnufied