Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16531: Upgraded openshift/library-go to remove indirect references to goproxy. #35

Merged
merged 1 commit into from Aug 4, 2023

Conversation

jaypoulz
Copy link
Contributor

@jaypoulz jaypoulz commented Aug 2, 2023

Technically, the linked bug isn't exposed by the modules in this repo. This patch aims to update the library-go module (and it's dependencies) so that we remove all indirect (but unused) references to goproxy.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 2, 2023
@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-16531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 2, 2023
@jaypoulz jaypoulz requested a review from Phaow August 2, 2023 18:38
@openshift-ci-robot
Copy link

@jaypoulz: This pull request references Jira Issue OCPBUGS-16531, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

In response to this:

Technically, the linked bug isn't exposed by the modules in this repo. This patch aims to update the library-go module (and it's dependencies) so that we remove all indirect (but unused) references to goproxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@jaypoulz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypoulz, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit d5fae48 into openshift:main Aug 4, 2023
4 checks passed
@openshift-ci-robot
Copy link

@jaypoulz: Jira Issue OCPBUGS-16531: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16531 has been moved to the MODIFIED state.

In response to this:

Technically, the linked bug isn't exposed by the modules in this repo. This patch aims to update the library-go module (and it's dependencies) so that we remove all indirect (but unused) references to goproxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants