Add detect-secrets tooling #150
Conversation
| "hashed_secret": "d2e2ab0f407e4ee3cf2ab87d61c31b25a74085e5", | ||
| "is_secret": false, | ||
| "is_verified": false, | ||
| "line_number": 14, |
There was a problem hiding this comment.
Why are we placing a secret in a configmap and not in a Kubernetes secret? I know this comment is unrelated to this PR but nonetheless, it is a security problem.
There was a problem hiding this comment.
The configmap is used to deliver an arbitrary CR to the child cluster via the boostrap pod. I'll open an issue to switch to a secret and have the bootstrap pod apply both configmaps and secrets.
|
@rtheis: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pre-commit config is in place, as well as a secret baseline file.
jonesbr17
force-pushed
the
detect-secrets
branch
from
51ab4ed
to
618dd6b
Compare
|
@rtheis: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@csrwng ptal |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jonesbr17, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.6 |
|
@jonesbr17: new pull request created: #152 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@jonesbr17: new pull request created: #153 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pre-commit config is in place, as well as a secret baseline file.