Bug 2047732: [IBM]Volume is not deleted after destroy cluster

[sameshai]

No description provided.

[openshift-ci]

Hi @sameshai. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

/ok-to-test
/assign @dobsonj
/retitle Bug 2047732: [IBM]Volume is not deleted after destroy cluster

[openshift-ci]

@sameshai: This pull request references Bugzilla bug 2047732, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2047732: [IBM]Volume is not deleted after destroy cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

/bugzilla refresh

[openshift-ci]

@jsafrane: This pull request references Bugzilla bug 2047732, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chao007

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/hold
from the driver logs, ibm-vpc-block-csi-controller fails to start with this change:

flag provided but not defined: -extra-labels

@sameshai was the -extra-labels argument added to a newer release of the driver? If so, can you point me to that change so we can get that pulled into the downstream fork before this PR merges?

[sameshai]

@dobsonj give me some time these changes are still under testing when everything is finalized, we will provide the details.

[openshift-ci]

@GunaKKIBM: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@sameshai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-csi	ff4825c	link	false	/test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sameshai]

/hold from the driver logs, ibm-vpc-block-csi-controller fails to start with this change:

flag provided but not defined: -extra-labels

@sameshai was the -extra-labels argument added to a newer release of the driver? If so, can you point me to that change so we can get that pulled into the downstream fork before this PR merges?

@dobsonj CSI driver is released v4.4.4. Can you pulled into the downstream fork? Followed this we can merge the operator PR
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/releases/tag/v4.4.4

[sameshai]

@dobsonj can we try the rebase now with 4.4.4

[dobsonj]

@dobsonj can we try the rebase now with 4.4.4

I tried testing just the 2 rebase PR's together and it failed since it didn't have the additional RBAC permissions from this PR. So there's a bit of a circular dependency:

• Bug 2047732: [IBM]Volume is not deleted after destroy cluster #40 depends on Rebase: ibm-vpc-block-csi-driver v4.4.4 ibm-vpc-block-csi-driver#14 to add the extra-labels argument
• Rebase: ibm-vpc-block-csi-driver v4.4.4 ibm-vpc-block-csi-driver#14 depends on Bug 2047732: [IBM]Volume is not deleted after destroy cluster #40 to add the RBAC permissions

I'm running a build now to test all 3 PR's together (operator, driver, labeler), we'll see how that goes.

[dobsonj]

I'm running a build now to test all 3 PR's together (operator, driver, labeler), we'll see how that goes.

The cluster came up with storage working, after building an image with all 3 PR's linked above.

[sameshai]

I'm running a build now to test all 3 PR's together (operator, driver, labeler), we'll see how that goes.

The cluster came up with storage working, after building an image with all 3 PR's linked above.

Thats great @dobsonj thanks for verifying

[dobsonj]

/lgtm
leaving the hold until openshift/ibm-vpc-block-csi-driver#14 and openshift/ibm-vpc-node-label-updater#11 are merged

[dobsonj]

/approve
/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, GunaKKIBM, sameshai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sameshai: All pull requests linked via external trackers have merged:

• openshift/ibm-vpc-block-csi-driver-operator#40
• openshift/installer#5962

Bugzilla bug 2047732 has been moved to the MODIFIED state.

In response to this:

Bug 2047732: [IBM]Volume is not deleted after destroy cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.