Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 98: Reformat code with go 1.19 (#98) #23

Merged
merged 1 commit into from Oct 6, 2022

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Oct 6, 2022

Formatting rules were updated in go 1.19. Reformat the code so it's valid both in go 1.18 and 1.19.
Prerequisite for #22

@openshift/storage

Formatting rules were updated in go 1.19. Reformat the code so it's valid
both in go 1.18 and 1.19.
@jsafrane
Copy link
Author

jsafrane commented Oct 6, 2022

/label qe-approved
/label px-approved
/label docs-approved

This updated just comments in go code.

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@dobsonj
Copy link
Member

dobsonj commented Oct 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5b31b01 into openshift:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants