Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] OCPBUGS-19424: Watch networkData Secrets for changes #100

Merged
merged 5 commits into from Oct 16, 2023
Merged

[release-4.11] OCPBUGS-19424: Watch networkData Secrets for changes #100

merged 5 commits into from Oct 16, 2023

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Sep 20, 2023

Backport of #96

@zaneb
OCPBUGS-13532: Respond to changes in Secrets
bac4fb4 
Secrets were not being cached, so we never noticed if they changed. If
the user modified a Secret the PreprovisioningImage would not be
updated, and baremetal-operator would refuse to accept it (since it
wouldn't match the latest version).

This was already implemented by
68cc920, but that change was
accidentally dropped almost immediately after, in a rebase of what
became 2413b14 and
b5cac5b, and nobody noticed.
@zaneb
OCPBUGS-13532: Actually respond to changes in Secrets
92e00f9 
Somehow I managed to miss out the most important part of the change in
e920fe9.
@zaneb
Update BMO to latest release-4.11
c2f1768
@zaneb
Update BuildImage() API
26255d0 
This API changed in recent versions of the upstream baremetal-operator.
@zaneb
OCPBUGS-14250: Update BMO dependency to watch owned Secrets
3898f61 
Ensure we watch Secrets we own even though the 'controller' flag is not
set in the owner reference.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2023
@openshift-ci-robot
Copy link

@zaneb: This pull request references Jira Issue OCPBUGS-19424, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18687 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of #96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@honza
Copy link
Member

honza commented Sep 20, 2023

/label backport-risk-assessed

1 similar comment
@honza
Copy link
Member

honza commented Sep 20, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 20, 2023
@zaneb
Copy link
Member Author

zaneb commented Sep 21, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 21, 2023
@openshift-ci-robot
Copy link

@zaneb: This pull request references Jira Issue OCPBUGS-19424, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18687 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-18687 targets the "4.12.z" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @sgoveas

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sgoveas September 21, 2023 03:16
@jadhaj
Copy link

jadhaj commented Sep 21, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 21, 2023
@zaneb
Copy link
Member Author

zaneb commented Oct 9, 2023

@honza can you give this an lgtm?

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit f199f91 into openshift:release-4.11 Oct 16, 2023
7 checks passed
@openshift-ci-robot
Copy link

@zaneb: Jira Issue OCPBUGS-19424: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19424 has been moved to the MODIFIED state.

In response to this:

Backport of #96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb zaneb mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

@honza honza Awaiting requested review from honza

@sgoveas sgoveas Awaiting requested review from sgoveas

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zaneb @openshift-ci-robot @honza @jadhaj @dtantsur