Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15599: configurable ironic agent vlan creation #109

Merged
merged 1 commit into from Dec 6, 2023
Merged

OCPBUGS-15599: configurable ironic agent vlan creation #109

merged 1 commit into from Dec 6, 2023

Conversation

tdomnesc
Copy link
Contributor

@tdomnesc tdomnesc commented Nov 21, 2023 •
edited

Disable vlan creation by default if nmstate is provided

IRONIC_AGENT_VLAN_INTERFACES env variable can be used to force "all" or "" in ironic agent config regardless of nmstate

https://issues.redhat.com/browse/OCPBUGS-15599

@tdomnesc tdomnesc changed the title configurable ironic agent vlan creation OCPBUGS-15599: configurable ironic agent vlan creation Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link

@tdomnesc: This pull request references Jira Issue OCPBUGS-15599, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Disable vlan creation by default if nmstate is provided

IRONIC_AGENT_VLAN_INTERFACES env variable can be used to force "all" or "" in ironic agent config regardless of nmstate

https://issues.redhat.com/browse/OCPBUGS-15599

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tdomnesc
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@tdomnesc: This pull request references Jira Issue OCPBUGS-15599, which is invalid:

  • expected the bug to target only the "4.15.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tdomnesc
Copy link
Contributor Author

/retest

@tdomnesc
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2023
@openshift-ci-robot
Copy link

@tdomnesc: This pull request references Jira Issue OCPBUGS-15599, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

@tdomnesc could you add unit tests for the default behavior to check that it depends on nmstate?

@tdomnesc
Copy link
Contributor Author

@dtantsur - if nmstate is not empty we run an external command: exec.Command("nmstatectl", "gc", "/dev/stdin"). I thought about it and can't come up with any decent way to unit test this.

@tdomnesc
OCPBUGS-15599: configurable ironic agent vlan creation
c69b566 
  disable vlan creation by default if nmstate is provided
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@tdomnesc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dtantsur
Copy link
Member

dtantsur commented Dec 5, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, tdomnesc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@elfosardo
Copy link
Contributor

/lgtm

1 similar comment
@elfosardo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 97d8765 into openshift:main Dec 6, 2023
8 checks passed
@openshift-ci-robot
Copy link

@tdomnesc: Jira Issue OCPBUGS-15599: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15599 has been moved to the MODIFIED state.

In response to this:

Disable vlan creation by default if nmstate is provided

IRONIC_AGENT_VLAN_INTERFACES env variable can be used to force "all" or "" in ironic agent config regardless of nmstate

https://issues.redhat.com/browse/OCPBUGS-15599

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-image-customization-controller-container-v4.16.0-202312061430.p0.g97d8765.assembly.stream for distgit ose-image-customization-controller.
All builds following this will include this PR.

@tdomnesc tdomnesc deleted the ironic-agent-vlans branch December 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tdomnesc @openshift-ci-robot @dtantsur @elfosardo @openshift-bot