Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

METAL-834: Add --metrics-addr argument to controller #110

Merged
merged 1 commit into from Jan 2, 2024
Merged

METAL-834: Add --metrics-addr argument to controller #110

merged 1 commit into from Jan 2, 2024

Conversation

honza
Copy link
Member

@honza honza commented Nov 29, 2023

We want to be able to override the bind address of the metrics server. Omitting the argument preserves the original behaviour for backwards compatibility.

@honza
Add --metrics-addr argument to controller
c1a55de 
We want to be able to override the bind address of the metrics server.
Omitting the argument preserves the original behaviour for backwards
compatibility.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@honza honza changed the base branch from main to release-4.14 November 30, 2023 19:35
@honza honza changed the base branch from release-4.14 to main November 30, 2023 19:35
@dtantsur
Copy link
Member

dtantsur commented Dec 4, 2023

/retest

@dtantsur
Copy link
Member

dtantsur commented Dec 4, 2023

/retitle NO-ISSUE: Add --metrics-addr argument to controller
/lgtm

@openshift-ci openshift-ci bot changed the title Add --metrics-addr argument to controller NO-ISSUE: Add --metrics-addr argument to controller Dec 4, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2023
@openshift-ci-robot
Copy link

@honza: This pull request explicitly references no jira issue.

In response to this:

We want to be able to override the bind address of the metrics server. Omitting the argument preserves the original behaviour for backwards compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

dtantsur commented Dec 4, 2023

/hold

@honza has indicated this still needs testing

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 4, 2023
@honza
Copy link
Member Author

honza commented Dec 4, 2023

I think it works as a standalone change --- the testing is more about the actual problem I'm trying to solve: running this on the bootstrap node in k8s mode.

@honza
Copy link
Member Author

honza commented Dec 12, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 95fc5ee and 2 for PR HEAD c1a55de in total

@zaneb
Copy link
Member

zaneb commented Dec 13, 2023

Please open a ticket for this. This is not a valid use of NO-ISSUE.

@honza
Copy link
Member Author

honza commented Dec 13, 2023 •
edited by openshift-ci bot

/retitle METAL-834: Add --metrics-addr argument to controller

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Add --metrics-addr argument to controller METAL-834: Add --metrics-addr argument to controller Dec 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2023 •
edited by openshift-ci bot

@honza: This pull request references METAL-834 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

We want to be able to override the bind address of the metrics server. Omitting the argument preserves the original behaviour for backwards compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@honza honza mentioned this pull request Dec 18, 2023
Merged
@honza
Copy link
Member Author

honza commented Dec 18, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5c15661 and 1 for PR HEAD c1a55de in total

iurygregory
iurygregory reviewed Dec 19, 2023
View reviewed changes
cmd/controller/main.go
Port: 0, // Add flag with default of 9443 when adding webhooks
Namespace: watchNamespace,
Cache: cacheOptions,
MetricsBindAddress: metricsBindAddr,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this lgtm, Just wondering if we should add TLS Config like we have in BMO and CBO...

@honza
Copy link
Member Author

honza commented Dec 19, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7eefbf6 and 0 for PR HEAD c1a55de in total

@openshift-ci-robot
Copy link

/hold

Revision c1a55de was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2023
@honza
Copy link
Member Author

honza commented Jan 2, 2024

/retest

@honza
Copy link
Member Author

honza commented Jan 2, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

@honza: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1b73a7c into openshift:main Jan 2, 2024
9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-image-customization-controller-container-v4.16.0-202401022351.p0.g1b73a7c.assembly.stream for distgit ose-image-customization-controller.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurygregory iurygregory iurygregory left review comments

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@honza @dtantsur @openshift-ci-robot @zaneb @openshift-bot @iurygregory