-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up our image building process #152
Conversation
/assign @dmage |
@sosiouxme fyi |
b4a7941
to
889a4c8
Compare
moving the binary output has screwed up a bunch of our scripts. need to revisit this. |
@dmage ok, i've updated this to at least work... it's pretty hacky so if you have a better suggestion i'm certainly open to it, but for now i think this gets us where we need to be... ultimately we can probably revisit all these built scripts since we don't have a need for cross-compilation any more (or at least so i assume... none of our operators are being cross-compiled currently). |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
remove an old/now unused dockerfile that was causing confusion
update our binary build process to always output to a single dir regardless of platform, this was requested by the ART team. I don't think we care about cross-platform building any more.