Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up our image building process #152

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jan 30, 2019

  1. remove an old/now unused dockerfile that was causing confusion

  2. update our binary build process to always output to a single dir regardless of platform, this was requested by the ART team. I don't think we care about cross-platform building any more.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

/assign @dmage

@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

@sosiouxme fyi

@bparees bparees force-pushed the dockerfile branch 2 times, most recently from b4a7941 to 889a4c8 Compare January 30, 2019 21:53
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@bparees bparees changed the title clean up our image building process [WIP] clean up our image building process Jan 30, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

moving the binary output has screwed up a bunch of our scripts. need to revisit this.

@bparees bparees changed the title [WIP] clean up our image building process clean up our image building process Jan 31, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 31, 2019

@dmage ok, i've updated this to at least work... it's pretty hacky so if you have a better suggestion i'm certainly open to it, but for now i think this gets us where we need to be... ultimately we can probably revisit all these built scripts since we don't have a need for cross-compilation any more (or at least so i assume... none of our operators are being cross-compiled currently).

@dmage
Copy link
Member

dmage commented Jan 31, 2019

failed to get a token for the user alice: the server could not find the requested resource (post users.user.openshift.io)
looks like the same problem as in openshift/cluster-image-registry-operator#180

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dmage
Copy link
Member

dmage commented Jan 31, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 51c81aa into openshift:master Jan 31, 2019
@bparees bparees deleted the dockerfile branch March 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants