Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy path from imageStream.HasBlob #155

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Remove legacy path from imageStream.HasBlob #155

merged 3 commits into from
Feb 7, 2019

Conversation

dmage
Copy link
Member

@dmage dmage commented Feb 1, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2019
@bparees
Copy link
Contributor

bparees commented Feb 1, 2019

i guess this is one way to figure out if the api is working or not..... :)

@dmage
Copy link
Member Author

dmage commented Feb 4, 2019

Oh, it seems we are going to finally drop support of image.openshift.io/manifestBlobStored!

@legionus
Copy link
Contributor

legionus commented Feb 4, 2019

awesome

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2019
@dmage dmage force-pushed the remove-legacy-image-stream-has-blob branch from 0af79df to 1918d99 Compare February 5, 2019 14:28
@dmage
Copy link
Member Author

dmage commented Feb 5, 2019

/retest

4 similar comments
@dmage
Copy link
Member Author

dmage commented Feb 5, 2019

/retest

@dmage
Copy link
Member Author

dmage commented Feb 5, 2019

/retest

@openshift-merge-robot
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

/retest

@dmage
Copy link
Member Author

dmage commented Feb 6, 2019

/assign @bparees @legionus
/retest

legionus
legionus approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@legionus legionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@legionus
Copy link
Contributor

legionus commented Feb 6, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, legionus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@legionus
Copy link
Contributor

legionus commented Feb 6, 2019

aws_vpc.new_vpc: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.

awesome

@dmage
Copy link
Member Author

dmage commented Feb 6, 2019

/retest

1 similar comment
@legionus
Copy link
Contributor

legionus commented Feb 6, 2019

/retest

@legionus
Copy link
Contributor

legionus commented Feb 6, 2019

aws_iam_role.master_role: Error creating IAM Role ci-op-c0750z1r-6ec77-master-role: EntityAlreadyExists: Role with name ci-op-c0750z1r-6ec77-master-role already exists.

awesome

@dmage
Copy link
Member Author

dmage commented Feb 6, 2019

/retest

@legionus
Copy link
Contributor

legionus commented Feb 7, 2019

/retest

2 similar comments
@legionus
Copy link
Contributor

legionus commented Feb 7, 2019

/retest

@dmage
Copy link
Member Author

dmage commented Feb 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 41d3e06 into openshift:master Feb 7, 2019
@dmage dmage deleted the remove-legacy-image-stream-has-blob branch August 18, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legionus legionus legionus approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees

@legionus legionus

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmage @bparees @legionus @openshift-merge-robot @openshift-ci-robot