Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1815562: refactor errors package #240

Merged
merged 2 commits into from Jun 8, 2020
Merged

Bug 1815562: refactor errors package #240

merged 2 commits into from Jun 8, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Jun 5, 2020 •
edited

This is a refactoring PR and has two changes:

  1. remove legacy checks (support of OpenShift 3.6 and below)
  2. make errors.Error an interface

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@dmage
Copy link
Member Author

dmage commented Jun 5, 2020

/retitle Bug 1815562: refactor error package

@openshift-ci-robot openshift-ci-robot changed the title WIP Bug 1815562: refactor error package Jun 5, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 5, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1815562, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1815562: refactor error package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 5, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1815562, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1815562: refactor error package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Jun 5, 2020

/assign @ricardomaraschini

@dmage
error getting secrets: <nil>
8eb3cdf 
Assigning a typed nil to the error interface gives a non-nil value.

That breaks the common pattern `if nil != nil { ... }`.

To avoid this problem, NewError should return an interface.
@ricardomaraschini
Copy link
Contributor

/retest

@dmage
Copy link
Member Author

dmage commented Jun 8, 2020

/retitle Bug 1815562: refactor errors package

@openshift-ci-robot openshift-ci-robot changed the title Bug 1815562: refactor error package Bug 1815562: refactor errors package Jun 8, 2020
ricardomaraschini
ricardomaraschini approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6592a41 into openshift:master Jun 8, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: All pull requests linked via external trackers have merged: openshift/image-registry#240. Bugzilla bug 1815562 has been moved to the MODIFIED state.

In response to this:

Bug 1815562: refactor errors package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmage @openshift-ci-robot @ricardomaraschini @openshift-merge-robot