Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1873129: Kubernetes 1.19.0 #242

Merged
merged 1 commit into from Aug 31, 2020
Merged

Bug 1873129: Kubernetes 1.19.0 #242

merged 1 commit into from Aug 31, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Jul 22, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@dmage dmage changed the title Kubernetes 1.19.0-rc.2 Kubernetes 1.19.0-rc.4 Aug 18, 2020
@dmage
Copy link
Member Author

dmage commented Aug 18, 2020

/retest

@dmage
Copy link
Member Author

dmage commented Aug 18, 2020

/assign @ricardomaraschini

ricardomaraschini
ricardomaraschini approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@ricardomaraschini
Copy link
Contributor

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
@dmage
Copy link
Member Author

dmage commented Aug 25, 2020

/retest

@dmage dmage changed the title Kubernetes 1.19.0-rc.4 Kubernetes 1.19.0 Aug 27, 2020
@dmage dmage changed the title Kubernetes 1.19.0 Bug 1873129: Kubernetes 1.19.0 Aug 27, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: This pull request references Bugzilla bug 1873129, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873129: Kubernetes 1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 27, 2020
@dmage
Copy link
Member Author

dmage commented Aug 31, 2020

/retest

ricardomaraschini
ricardomaraschini approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ef17f50 into openshift:master Aug 31, 2020
@openshift-ci-robot
Copy link
Contributor

@dmage: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1873129 has not been moved to the MODIFIED state.

In response to this:

Bug 1873129: Kubernetes 1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmage @ricardomaraschini @openshift-ci-robot @openshift-merge-robot