Bug 1883502: Migrating from k8s.io/klog v1 to k8s.io/klog v2 #249
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ricardomaraschini: This pull request references Bugzilla bug 1883502, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
Used library-go version was relying on klog v1, bumping it to the newest version. As a consequence an update on Dockerfile was needed (to use go version 1.15).
Migrated from k8s.io/klog v1 to k8s.io/klog v2.
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -1,4 +1,4 @@ | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.13 AS builder | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.15 AS builder | |||
There was a problem hiding this comment.
is it something we want to backport to 4.6?
There was a problem hiding this comment.
IIUC the other option would be not to port this klog v2 to 4.6 at all. When we bump library-go we need to also bump go as it uses a tls variable/constant that does not exist on go 1.13.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ricardomaraschini: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1883502 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kubernetes 1.19 is leveraging k8s.io/klog v2. This PR updates references we still have to v1 to v2.