New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround /etc/pki/ca-trust bug on OpenShift 4.6 #254
Conversation
/retest |
b17a4cb
to
7ffea52
Compare
Dockerfile
Outdated
@@ -7,7 +7,7 @@ FROM registry.svc.ci.openshift.org/openshift/origin-v4.0:base | |||
RUN yum install -y rsync && yum clean all && rm -rf /var/cache/yum | |||
COPY --from=builder /go/src/github.com/openshift/image-registry/_output/local/bin/dockerregistry /usr/bin/ | |||
COPY images/dockerregistry/config.yml / | |||
RUN chmod a+w -R /etc/pki/ca-trust/extracted | |||
ADD images/dockerregistry/writable-pem.tar.gz /etc/pki/ca-trust/extracted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmage I may be wrong about this but since we are now mounting to /etc/pki/ca-trust during runtime this won't work right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akhil-rane ADD works on a different level. Even if something is mounted there, ADD will still create a new layer with files, so these files will be added to the image ignoring the mounted file systems. These files won't be visible during build in this case.
/retest |
3 similar comments
/retest |
/retest |
/retest |
/assign @ricardomaraschini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.