Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround /etc/pki/ca-trust bug on OpenShift 4.6 #254

Merged
merged 1 commit into from Nov 2, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Oct 27, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@dmage
Copy link
Member Author

dmage commented Oct 27, 2020

/retest

@gabemontero gabemontero removed their request for review October 27, 2020 13:23
@dmage dmage force-pushed the ci-workaround branch 2 times, most recently from b17a4cb to 7ffea52 Compare October 30, 2020 18:47
Dockerfile Outdated
@@ -7,7 +7,7 @@ FROM registry.svc.ci.openshift.org/openshift/origin-v4.0:base
RUN yum install -y rsync && yum clean all && rm -rf /var/cache/yum
COPY --from=builder /go/src/github.com/openshift/image-registry/_output/local/bin/dockerregistry /usr/bin/
COPY images/dockerregistry/config.yml /
RUN chmod a+w -R /etc/pki/ca-trust/extracted
ADD images/dockerregistry/writable-pem.tar.gz /etc/pki/ca-trust/extracted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmage I may be wrong about this but since we are now mounting to /etc/pki/ca-trust during runtime this won't work right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhil-rane ADD works on a different level. Even if something is mounted there, ADD will still create a new layer with files, so these files will be added to the image ignoring the mounted file systems. These files won't be visible during build in this case.

@dmage
Copy link
Member Author

dmage commented Oct 31, 2020

/retest

3 similar comments
@dmage
Copy link
Member Author

dmage commented Oct 31, 2020

/retest

@dmage
Copy link
Member Author

dmage commented Nov 1, 2020

/retest

@dmage
Copy link
Member Author

dmage commented Nov 1, 2020

/retest

@dmage
Copy link
Member Author

dmage commented Nov 2, 2020

/assign @ricardomaraschini

Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8df3d87 into openshift:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants