IR-114: Adding support for OCI schema #255
Conversation
This patch adds support for OCI schema into the internal registry. OCI schemas are very similar to Docker schema v2 thus this patch only creates a new manifest handler (very similar to docker schema v2 handler) and register it as a known schema handler.
ricardomaraschini
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold keep this on hold until we get all needed approvals. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/assign @dmage |
Integration test pushes an OCI image and verifies it got correctly processed.
test/integration/oci/oci_test.go
Outdated
| t.Errorf("error getting image stream: %s", err) | ||
| } | ||
| if len(is.Status.Tags) != 1 { | ||
| t.Fatal("no tag found in image stream") |
There was a problem hiding this comment.
the error message will be misleading if there are more than 1 tag
There was a problem hiding this comment.
Done. PTAL.
| dgst, | ||
| is.Status.Tags[0].Items[0].Image, | ||
| ) | ||
| } |
There was a problem hiding this comment.
It's better to check that the image object has proper mediatype and information about the config blob.
There was a problem hiding this comment.
Done. PTAL.
Changed a test to also validate if the imported oci manifest points to the correct config by its sha.
|
/retest |
1 similar comment
|
/retest |
|
/approve |
openshift-ci-robot
added
the
approved
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/assign @wzheng1 @bmcelvee @sferich888 The registry tests are flaky, but eventually they'll be green. The PRs is ready for review. |
|
/retest |
|
@ricardomaraschini: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini, wzheng1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/label docs-approved |
openshift-ci-robot
added
the
docs-approved
|
@sferich888 we miss your ack on this one |
|
/label qe-approved |
openshift-ci-robot
added
the
qe-approved
|
/label px-approved |
openshift-ci-robot
added
the
px-approved
|
/unhold Approved by all stakeholders. |
openshift-ci-robot
removed
the
do-not-merge/hold
bparees
added
the
bugzilla/valid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This patch adds support for OCI schema into the internal registry. OCI
schemas are very similar to Docker schema v2 thus this patch only
creates a new manifest handler (very similar to docker schema v2
handler) and register it as a known schema handler.