Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2012163: Supporting mirror authentication during pull through #297

Merged
merged 2 commits into from Oct 21, 2021
Merged

Bug 2012163: Supporting mirror authentication during pull through #297

merged 2 commits into from Oct 21, 2021

Conversation

dmage
Copy link
Member

@dmage dmage commented Oct 18, 2021

Backport of #281.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@dmage: This pull request references Bugzilla bug 2012163, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1972009 is in the state RELEASE_PENDING, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1972009 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 2012163: Supporting mirror authentication during pull through

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@dmage
Copy link
Member Author

dmage commented Oct 18, 2021

/assign @ricardomaraschini

ricardomaraschini
ricardomaraschini approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@xiuwang
Copy link

xiuwang commented Oct 19, 2021

Launch cluster from pr.

Steps to validate:
1.Create a restricted cluster
2.Mirror image to mirror registry(enabled auth)
3.Create pullthough imagestream
4.Deploy pod using the pullthough imagestream

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 19, 2021
@mrunalp
Copy link
Member

mrunalp commented Oct 20, 2021

Could you get a backport-risk-assessed from the team?

@dmage
Copy link
Member Author

dmage commented Oct 20, 2021

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2021

@dmage: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Oct 20, 2021 •
edited

¯\_(ツ)_/¯

@dmage
Copy link
Member Author

dmage commented Oct 20, 2021

We need to update configs for our repos

@dmage
Copy link
Member Author

dmage commented Oct 21, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 21, 2021
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 369fd30 into openshift:release-4.8 Oct 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 2012163 has been moved to the MODIFIED state.

In response to this:

Bug 2012163: Supporting mirror authentication during pull through

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@xiuwang xiuwang Awaiting requested review from xiuwang

@gabemontero gabemontero Awaiting requested review from gabemontero

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmage @openshift-bot @xiuwang @mrunalp @ricardomaraschini @openshift-merge-robot