Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1092: Revert "Merge pull request #370 from flavianmissi/bump-docker-distrib… #371

Merged
merged 1 commit into from Jun 16, 2023
Merged

TRT-1092: Revert "Merge pull request #370 from flavianmissi/bump-docker-distrib… #371

merged 1 commit into from Jun 16, 2023

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jun 16, 2023

Reverts # image-registry/pull/370; tracked by TRT-1092

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Observing CI Hypershift failures in 4.14.0-0.ci-2023-06-16-074926

@neisw
Revert "Merge pull request openshift#370 from flavianmissi/bump-docke…
81fae2e 
…r-distribution"

This reverts commit b095928, reversing
changes made to 92c7270.
@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: trigger 0 job(s) for the /payload-(job|aggregate) command

@neisw neisw changed the title Revert "Merge pull request #370 from flavianmissi/bump-docker-distrib… TRT-1092: Revert "Merge pull request #370 from flavianmissi/bump-docker-distrib… Jun 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2023 •
edited by openshift-ci bot

@neisw: This pull request references TRT-1092 which is a valid jira issue.

In response to this:

Reverts # image-registry/pull/370; tracked by TRT-1092

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Observing CI Hypershift failures in 4.14.0-0.ci-2023-06-16-074926

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload 4.14 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/45fd29f0-0c6a-11ee-81f8-af78fde83ce0-0

@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload cancel

@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: aborted active payload jobs for pull request #371

@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. could not check if the user neisw is trusted for pull request openshift/image-registry#371: error checking neisw for trust: error in IsMember(openshift): Get "http://ghproxy/orgs/openshift/members/neisw": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue.

@neisw
Copy link
Contributor Author

neisw commented Jun 16, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@neisw: trigger 0 job(s) for the /payload-(job|aggregate) command

@stbenjam
Copy link
Member

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@stbenjam: trigger 0 job(s) for the /payload-(job|aggregate) command

@stbenjam
Copy link
Member

/lgtm
/label approved
/label jira/valid-bug

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@stbenjam
Copy link
Member

stbenjam commented Jun 16, 2023 •
edited

Tagging to merge to get payloads green again. We think the evidence is pretty strong this is what broke hypershift.

We can't trigger the payload job, but if for some reason we're wrong will unrevert this quickly.

@stbenjam
Copy link
Member

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@openshift-merge-robot openshift-merge-robot merged commit ad3b187 into openshift:master Jun 16, 2023
9 checks passed
@Miciah Miciah mentioned this pull request Jun 18, 2023
Merged
@jmguzik
Copy link

jmguzik commented Jul 5, 2023

/payload 4.14 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

@jmguzik: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0fa109a0-1b36-11ee-81c9-b84c96ed0d04-0

@jmguzik
Copy link

jmguzik commented Jul 5, 2023

(just testing sth)

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

@jmguzik: trigger 0 job(s) for the /payload-(job|aggregate) command

@jmguzik
Copy link

jmguzik commented Jul 5, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

@jmguzik: trigger 0 job(s) for the /payload-(job|aggregate) command

@jmguzik
Copy link

jmguzik commented Jul 19, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@jmguzik: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14efa840-2625-11ee-95de-4e06e0282ec1-0

@jmguzik
Copy link

jmguzik commented Jul 19, 2023

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@jmguzik: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96c128e0-2629-11ee-9250-8d9bcc14361c-0

@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neisw @openshift-ci-robot @stbenjam @jmguzik @openshift-merge-robot