Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR-401: pkg/dockerregistry/server/configuration: remove OPENSHIFT_DEFAULT_REGISTRY support #378

Merged
merged 2 commits into from Oct 23, 2023
Merged

IR-401: pkg/dockerregistry/server/configuration: remove OPENSHIFT_DEFAULT_REGISTRY support #378

merged 2 commits into from Oct 23, 2023

Conversation

flavianmissi
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from dmage and mfojtik September 4, 2023 14:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@flavianmissi flavianmissi changed the title pkg/dockerregistry/server/configuration: remove OPENSHIFT_DEFAULT_REGISTRY support IR-401: pkg/dockerregistry/server/configuration: remove OPENSHIFT_DEFAULT_REGISTRY support Sep 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 4, 2023 •
edited by openshift-ci bot

@flavianmissi: This pull request references IR-401 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2023
@flavianmissi
pkg/dockerregistry/server/configuration: remove OPENSHIFT_DEFAULT_REG…
6bd6aac 
…ISTRY support

also remove support for DOCKER_REGISTRY_SERVICE_HOST and DOCKER_REGISTRY_SERVICE_PORT
env vars.
@flavianmissi
Copy link
Member Author

failure seems unrelated

@flavianmissi
Copy link
Member Author

/retest

flavianmissi added a commit to flavianmissi/api that referenced this pull request Sep 6, 2023
@flavianmissi
remove references to OPENSHIFT_DEFAULT_REGISTRY
333e50e 
OPENSHIFT_DEFAULT_REGISTRY has been deprecated and is removed by
openshift/image-registry#378
flavianmissi added a commit to flavianmissi/api that referenced this pull request Sep 6, 2023
@flavianmissi
remove references to OPENSHIFT_DEFAULT_REGISTRY
36f19ad 
OPENSHIFT_DEFAULT_REGISTRY has been deprecated and is removed by
openshift/image-registry#378
@flavianmissi flavianmissi mentioned this pull request Sep 6, 2023
Merged
@flavianmissi
Copy link
Member Author

e2e failure seems unrelated
/retest

@dmage
Copy link
Member

dmage commented Sep 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flavianmissi
Copy link
Member Author

@xiuwang or @wewang58 could either of you help with qe approval?
This removes support for the legacy OPENSHIFT_DEFAULT_REGISTRY env var, which used to be a way to customise the registry address.
Thank you!

@sferich888
Copy link

What feature is this connected to?

@flavianmissi
Copy link
Member Author

What feature is this connected to?

Hi @sferich888,
This first came up when solving OCPBUGS-17674 (see openshift/openshift-apiserver#387). This is cleanup work and it's not currently part of any feature.

@stevsmit
Copy link
Member

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 20, 2023
@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 17, 2023
@wewang58
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2023 •
edited by openshift-ci bot

@flavianmissi: This pull request references IR-401 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 855b24b into openshift:master Oct 23, 2023
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-registry-container-v4.15.0-202311202349.p0.g855b24b.assembly.stream for distgit openshift-enterprise-registry.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flavianmissi @openshift-ci-robot @dmage @sferich888 @stevsmit @wewang58 @openshift-bot