Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-31641: vendor: bump aws-sdk-go to support ca-west-1 #396

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #395

/assign flavianmissi

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-29233 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.15] OCPBUGS-31641: vendor: bump aws-sdk-go to support ca-west-1

In response to this:

This is an automated cherry-pick of #395

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-29233: vendor: bump aws-sdk-go to support ca-west-1 [release-4.15] OCPBUGS-31641: vendor: bump aws-sdk-go to support ca-west-1 Apr 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 19, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31641, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29233 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #395

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@flavianmissi
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@flavianmissi: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wewang58
Copy link

Pre-merge tested, image registry is available
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 19, 2024
@wewang58
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 19, 2024
@wewang58
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@wewang58: This pull request references Jira Issue OCPBUGS-31641, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29233 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wewang58
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 19, 2024
@openshift-ci-robot
Copy link
Contributor

@wewang58: This pull request references Jira Issue OCPBUGS-31641, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-29233 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29233 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wewang58 April 19, 2024 12:37
@flavianmissi
Copy link
Member

I want there to be a nightly build and payload tests to run against master before we merge this, so I'm going to approve but will hold for the moment.
/lgtm
/label backport-risk-assessed
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 19, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0a844cb into openshift:release-4.15 Apr 22, 2024
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31641: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31641 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #395

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@flavianmissi: #396 failed to apply on top of branch "release-4.14":

Applying: vendor: bump aws-sdk-go to support ca-west-1
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/github.com/aws/aws-sdk-go/aws/config.go
A	vendor/github.com/aws/aws-sdk-go/aws/credentials/ssocreds/token_provider.go
M	vendor/github.com/aws/aws-sdk-go/aws/ec2metadata/token_provider.go
M	vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go
M	vendor/github.com/aws/aws-sdk-go/aws/session/session.go
M	vendor/github.com/aws/aws-sdk-go/aws/session/shared_config.go
M	vendor/github.com/aws/aws-sdk-go/aws/signer/v4/v4.go
M	vendor/github.com/aws/aws-sdk-go/aws/version.go
M	vendor/github.com/aws/aws-sdk-go/service/s3/api.go
A	vendor/github.com/aws/aws-sdk-go/service/ssooidc/api.go
A	vendor/github.com/aws/aws-sdk-go/service/ssooidc/doc.go
A	vendor/github.com/aws/aws-sdk-go/service/ssooidc/errors.go
A	vendor/github.com/aws/aws-sdk-go/service/ssooidc/service.go
M	vendor/github.com/aws/aws-sdk-go/service/sts/api.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/golang.org/x/sys/internal/unsafeheader/unsafeheader.go
Removing vendor/golang.org/x/net/http2/Makefile
Removing vendor/golang.org/x/net/http2/Dockerfile
Auto-merging vendor/github.com/aws/aws-sdk-go/service/sts/api.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/service/sts/api.go
CONFLICT (modify/delete): vendor/github.com/aws/aws-sdk-go/service/ssooidc/errors.go deleted in HEAD and modified in vendor: bump aws-sdk-go to support ca-west-1. Version vendor: bump aws-sdk-go to support ca-west-1 of vendor/github.com/aws/aws-sdk-go/service/ssooidc/errors.go left in tree.
CONFLICT (modify/delete): vendor/github.com/aws/aws-sdk-go/service/ssooidc/doc.go deleted in HEAD and modified in vendor: bump aws-sdk-go to support ca-west-1. Version vendor: bump aws-sdk-go to support ca-west-1 of vendor/github.com/aws/aws-sdk-go/service/ssooidc/doc.go left in tree.
CONFLICT (modify/delete): vendor/github.com/aws/aws-sdk-go/service/ssooidc/api.go deleted in HEAD and modified in vendor: bump aws-sdk-go to support ca-west-1. Version vendor: bump aws-sdk-go to support ca-west-1 of vendor/github.com/aws/aws-sdk-go/service/ssooidc/api.go left in tree.
Auto-merging vendor/github.com/aws/aws-sdk-go/service/sso/service.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/service/sso/service.go
Auto-merging vendor/github.com/aws/aws-sdk-go/service/s3/api.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/service/s3/api.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/version.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/aws/version.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/signer/v4/v4.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/session/shared_config.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/session/session.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/aws/session/session.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/ec2metadata/token_provider.go
CONFLICT (content): Merge conflict in vendor/github.com/aws/aws-sdk-go/aws/ec2metadata/token_provider.go
CONFLICT (modify/delete): vendor/github.com/aws/aws-sdk-go/aws/credentials/ssocreds/token_provider.go deleted in HEAD and modified in vendor: bump aws-sdk-go to support ca-west-1. Version vendor: bump aws-sdk-go to support ca-west-1 of vendor/github.com/aws/aws-sdk-go/aws/credentials/ssocreds/token_provider.go left in tree.
Auto-merging vendor/github.com/aws/aws-sdk-go/aws/config.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 vendor: bump aws-sdk-go to support ca-west-1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-registry-container-v4.15.0-202404220846.p0.g0a844cb.assembly.stream.el9 for distgit openshift-enterprise-registry.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-04-23-013140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants