BUG: labels following missing line-continuation character are ignored

[ben-alkov]

e.g.

LABEL name="tech-preview/vm-launcher" \
      version="v0.0.1" \
      release="10"
      summary="Hosts VMs" \

does NOT fail as expected, but simply ignores all labels following release.

podman fails as expected.

[nalind]

When I try to build this Dockerfile with the current version:

FROM scratch
LABEL name="tech-preview/vm-launcher" \
      version="v0.0.1" \
      release="10"
      summary="Hosts VMs" \

the build completes, but I get a --> warning: Unknown instruction: SUMMARY="HOSTS warning in the output. If I build with the -ignore-unrecognized-instructions=false flag, the build errors out. Are you seeing different behavior? Are you using a different release of imagebuilder?

(edited: I forgot the FROM scratch)

[ben-alkov]

Unfortunately, I'm not able to even build a reproducer right now, but AFAIK:

the build completes, but I get a --> warning: Unknown instruction: SUMMARY="HOSTS warning in the output

Our builds complete; build owners are probably simply ignoring that warning

If I build with the -ignore-unrecognized-instructions=false flag, the build errors out. Are you seeing different behavior?

We always build with --ignore-unrecognized-instructions=true

Are you using a different release of imagebuilder?

1.2.1

[nalind]

If I build with the -ignore-unrecognized-instructions=false flag, the build errors out. Are you seeing different behavior?

We always build with --ignore-unrecognized-instructions=true

I am sorely tempted to try to change the default for that from true to false.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.