Handle COPY --from=${number} #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
rhatdan
approved these changes
Jul 31, 2021
dockerclient/client.go
Outdated
| @@ -163,6 +168,7 @@ func (e *ClientExecutor) WithName(name string) *ClientExecutor { | |||
|
|
|||
| child := &copied | |||
| e.Named[name] = child | |||
| e.Named[fmt.Sprintf("%d", position)] = child | |||
There was a problem hiding this comment.
Why not use strconf.Itoa() it is supposed to be more efficient.
There was a problem hiding this comment.
Only that I forgot about that function. Changing it.
Handle COPY --from=${stage} where the referred-to stage is referred to
by its order in the build, and add a couple of test Dockerfiles that
test COPY --from=${stage}, where ${stage} is a number.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
copy-from-numeric
branch
from
c735af9
to
49da39a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle COPY --from=${stage} where the referred-to stage is referred to by its order in the build, and add a couple of test Dockerfiles that test COPY --from=${stage}, where ${stage} is a number. Conformance tests don't currently handle multi-stage builds, but we add a couple of samples for manual smoke testers.