dockerclient COPY --from: go back and copy skipped hard link targets #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
nalind
force-pushed
the
copy-omitted-hard-links
branch
2 times, most recently
from
2a3d4ca
to
73e7f81
Compare
If we're copying from another stage or from an archive, and we encounter an entry that we need to copy that should be hard linked to an entry that we would have skipped, run through another copy of the archive, convert the hard link entry we're processing into a regular file entry, and use the contents of the skipped item as the contents for the regular file entry. Rewrite any subsequent links to the skipped entry into links to the first link, which we converted into the regular file. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
copy-omitted-hard-links
branch
from
73e7f81
to
9ce1781
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're copying from another stage or from an archive, and we encounter an entry that we need to copy that should be hard linked to an entry that we would have skipped, run through another copy of the archive, convert the hard link entry we're processing into a regular file entry, and use the contents of the skipped item as the contents for the regular file entry. Rewrite any subsequent links to the skipped entry into links to the first link, which we converted into the regular file.
Fixes #202.