calcCopyInfo: also trim leading path on rootPath #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
nalind
added
the
do-not-merge/hold
nalind
force-pushed
the
copyinfo-subdir
branch
from
7bf2a2b
to
04e2c46
Compare
nalind
removed
the
do-not-merge/hold
nalind
force-pushed
the
copyinfo-subdir
branch
from
04e2c46
to
6fe1912
Compare
|
LGTM |
calcCopyInfo trims a leading "./" or "/./" from one of its parameters, but not the other, which can break COPY instructions when the build context location is specified using a path that starts with "./". Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
copyinfo-subdir
branch
from
6fe1912
to
a51a702
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calcCopyInfo trims a leading "./" or "/./" from one of its parameters, but not the other, which can break COPY instructions when the build context location is specified using a path that starts with "./".