Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerclient: COPY --from should ignore the source's WORKDIR #215

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Feb 2, 2022

When COPY is given --from=${stage|image}, the stage's or image's WORKDIR should not be incorporated into the path where we go to look for the source when the source is not specified with an absolute path name. We previously incorporated the WORKDIR value, but that is not compatible with what docker build does.

When COPY is given --from=${stage|image}, the stage's or image's WORKDIR
should not be incorporated into the path where we go to look for the
source when the source is not specified with an absolute path name.
We previously incorporated the WORKDIR value, but that is not compatible
with what `docker build` does.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@rhatdan
Copy link
Contributor

rhatdan commented Feb 2, 2022

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrothberg
Copy link
Member

LGTM

@vrothberg
Copy link
Member

I don't think I can merge here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f12ae40 into openshift:master Feb 2, 2022
@nalind nalind deleted the copy-from-workdir branch February 2, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants