dockerclient: fix COPYing an archive to a new location #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that the Decompress field from CopyInfo is never set and ignored. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When COPYing an archive to a location which doesn't exist, don't force the destination to be treated as a directory that we might have to create. We have to do that for ADD in order to be able to extract the archive's contents, but not for COPY. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-ci
bot
added
the
approved
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When COPYing an archive to a location which doesn't exist, don't force the destination to be treated as a directory that we might have to create. We have to do that for ADD in order to be able to extract the archive's contents, but not for COPY.
Document that the
Decompressfield fromdockerclient.CopyInfois both never set and ignored.Should fix #230.