Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to golang native error wrapping #240

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

saschagrunert
Copy link
Member

The package github.com/pkg/errors is deprecated and we can use golang native error wrapping instead.

@openshift-ci openshift-ci bot requested review from nalind and rhatdan January 19, 2023 11:01
@TomSweeneyRedHat
Copy link
Contributor

LGTM
once the tests are hip

@saschagrunert
Copy link
Member Author

The CI seems to fail for the same reason on master. 🤔

@rhatdan
Copy link
Contributor

rhatdan commented Feb 8, 2023

@saschagrunert could you rebase.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@saschagrunert
Copy link
Member Author

Yep, done

@rhatdan
Copy link
Contributor

rhatdan commented Feb 8, 2023

@saschagrunert one more rebase...

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2023
The package `github.com/pkg/errors` is deprecated and we can use golang
native error wrapping instead.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Done one more 👍

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nalind
Copy link
Member

nalind commented Feb 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit bfba00f into openshift:master Feb 9, 2023
@saschagrunert saschagrunert deleted the err-wrap branch February 9, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants