Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-1833: dockerclient: use /bin/sleep for idling instead of sleep #256

Merged
merged 1 commit into from
May 18, 2023

Conversation

nalind
Copy link
Member

@nalind nalind commented May 16, 2023

The built-in "sleep" in the latest alpine base image's shell behaves differently from the version it has to exec(), exiting when it receives a stray SIGCHLD for one of the processes we're running in an exec session, and this is causing a consistent failure in the "copy and env interaction" conformance test.
Call /bin/sleep explicitly to work around this.

Note to other maintainers: please do not /lgtm until Travis is green.

The built-in "sleep" in the latest alpine base image's shell behaves
differently from the version it has to exec(), exiting when it receives
a stray SIGCHLD for one of the processes we're running in an exec
session, and this is causing a consistent failure in the "copy and env
interaction" conformance test.  Call /bin/sleep explicitly to work
around this.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2023

@nalind: This pull request references RUN-1833 which is a valid jira issue.

In response to this:

The built-in "sleep" in the latest alpine base image's shell behaves differently from the version it has to exec(), exiting when it receives a stray SIGCHLD for one of the processes we're running in an exec session, and this is causing a consistent failure in the "copy and env interaction" conformance test.
Call /bin/sleep explicitly to work around this.

Note to other maintainers: please do not /lgtm until Travis is green.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Contributor

LGTM
and happy green test buttons.

@rhatdan
Copy link
Contributor

rhatdan commented May 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a42843 into openshift:master May 18, 2023
3 checks passed
@nalind nalind deleted the non-builtin-sleep branch May 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants