Update dependencies, keep up with API changes #276
Conversation
|
This blocks containers/buildah#5301. I expect to tag a release once this is merged. |
openshift-ci
bot
added
the
approved
|
FWIW, Docker is not using Go modules the usual way, meaning The dependencies are managed in a file named Doing so here causes a few more (fairly minor) updates. |
|
Oh, I wasn't aware. Worth doing since there's no automation in this repository for it. |
* bump github.com/containerd/containerd from v1.7.11 to v1.7.13 * bump github.com/docker/docker from v24.0.7 to v25.0.1 * bump github.com/fsouza/go-dockerclient from v1.9.7 to v1.10.1 * bump github.com/containers/storage from v1.51.0 to v1.52.0 * bump github.com/moby/buildkit from v0.11.4 to v0.12.5 Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
The github.com/docker/docker/api/types.AuthConfig type was moved to the github.com/docker/docker/api/types/registry package, so our declarations for variables of that type need to be updated. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
@nalind tests aren't hip |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Unit tests are waiting on openshift/release#48288. I don't have the privileges to see what the errors are in the Go 1.21 build in Travis, but it's passing with 1.20. |
|
Can we keep it at 1.20 for now? |
Update which versions of Go Travis uses for testing to just use one version. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
I guess. |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/test unit |
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Unit tests are passing now that openshift/release#48288 is merged, and Travis is only testing with 1.20. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
The
github.com/docker/docker/api/types.AuthConfigtype was moved to thegithub.com/docker/docker/api/types/registrypackage, and the type alias that allowed us to not care has gone, so our declarations for variables of that type need to be updated.