Trim trailing path separators from WORKDIR values #283
Conversation
openshift-ci
bot
added
the
approved
dispatchers.go
Outdated
| @@ -372,6 +372,10 @@ func workdir(b *Builder, args []string, attributes map[string]bool, flagArgs []s | |||
| workdir = filepath.Join(string(os.PathSeparator), current, workdir) | |||
| } | |||
|
|
|||
| if trimmed := strings.TrimSuffix(workdir, string(os.PathSeparator)); trimmed != "" { | |||
There was a problem hiding this comment.
This code is a a little confusing, would
if workdir != os.PathSepator {
workdir= strings.TrimSuffix(workdir, string(os.PathSeparator))
}
Make easier to understand?
|
LGTM other then small code suggestion. |
nalind
force-pushed
the
workdir-trailing-separator
branch
from
89820cc
to
48647b3
Compare
Compatibility requires that we trim trailing path separators from WORKDIR values. Update a test that refers to a git repository to catch up with that repository's contents. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
workdir-trailing-separator
branch
from
48647b3
to
8fca88b
Compare
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
Compatibility requires that we trim trailing path separators from WORKDIR values. This should resolve containers/buildah#5526 (comment).