Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1444: egress/dns-proxy: switch to haproxy28 RPM package #160

Merged
merged 1 commit into from Feb 12, 2024
Merged

NE-1444: egress/dns-proxy: switch to haproxy28 RPM package #160

merged 1 commit into from Feb 12, 2024

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Jan 12, 2024 •
edited

  • Bump haproxy package from haproxy26 to haproxy28.
  • Bump base image to 4.16 RHEL 9 as haproxy28 RPM is only tagged in RHEL 9.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2024 •
edited by openshift-ci bot

@frobware: This pull request references NE-1444 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from candita and gcs278 January 12, 2024 10:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@frobware
Copy link
Contributor Author

/hold

We can remove the hold once we have committed to haproxy 2.8 and have an RPM built.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@frobware frobware mentioned this pull request Jan 12, 2024
Closed
@frobware frobware marked this pull request as draft January 12, 2024 10:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2024 •
edited by openshift-ci bot

@frobware: This pull request references NE-1444 which is a valid jira issue.

In response to this:

Bump haproxy package from haproxy26 to haproxy28.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware frobware mentioned this pull request Jan 12, 2024
Merged
@gcs278
Copy link
Contributor

gcs278 commented Feb 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@frobware
Copy link
Contributor Author

frobware commented Feb 8, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@frobware frobware marked this pull request as ready for review February 8, 2024 20:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@openshift-ci openshift-ci bot requested a review from knobunc February 8, 2024 20:07
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 676f4f6 and 2 for PR HEAD 2ebbedf in total

@frobware
Copy link
Contributor Author

frobware commented Feb 9, 2024

https://ocp-artifacts.hosts.prod.psi.rdu2.redhat.com/pub/RHOCP/plashets/4.16/stream/el9/latest/x86_64/os/Packages/haproxy-2.8.5-1.rhaos4.16.el9__x86_64/ is now availbe.

/hold cancel

@frobware
Copy link
Contributor Author

frobware commented Feb 9, 2024

/test all

@frobware
Copy link
Contributor Author

frobware commented Feb 9, 2024 •
edited

Oh! This image is still based on RHEL 8. In which case we need to stick with HAProxy 2.6. Hmm.

@frobware
Copy link
Contributor Author

frobware commented Feb 9, 2024

#158 is still outstanding for OCP 4.16.

@frobware
Copy link
Contributor Author

frobware commented Feb 9, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 247d4a0 and 1 for PR HEAD 2ebbedf in total

@frobware
Copy link
Contributor Author

/test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@frobware frobware changed the title NE-1444: container builds: switch to haproxy28 RPM package NE-1444: egress/dns-proxy: switch to haproxy28 RPM package Feb 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2024 •
edited by openshift-ci bot

@frobware: This pull request references NE-1444 which is a valid jira issue.

In response to this:

  • Bump haproxy package from haproxy26 to haproxy28.
  • Bump base image to 4.16 RHEL 9 as haproxy28 RPM is only tagged in RHEL 9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware
NE-1444: egress/dns-proxy: switch to haproxy28 RPM package
3d1e257 
Bump haproxy from haproxy26 to haproxy28. Also bump base Dockerfile
image to 4.16:base-rhel9 as the haproxy28 RPM is only tagged in RHEL
9.
@frobware frobware force-pushed the NE-1444-switch-container-builds-to-haproxy28 branch from 6d88430 to 3d1e257 Compare February 12, 2024 11:54
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@frobware: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278
Copy link
Contributor

gcs278 commented Feb 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3d75237 into openshift:master Feb 12, 2024
4 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-base-rhel9-container-v4.16.0-202402121808.p0.g3d75237.assembly.stream.el9 for distgit openshift-enterprise-base-rhel9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@gcs278 gcs278 Awaiting requested review from gcs278

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@gcs278 gcs278

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frobware @openshift-ci-robot @gcs278 @openshift-bot @openshift-merge-robot