Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29484: update unit tests in egress/dns-proxy #165

Merged

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Feb 15, 2024

This PR introduces a go.mod file to the top of the tree, enabling the execution of go test. Unit tests are enabled with openshift/release#48854.

It also fixes the unit tests in egress/dns-proxy/egress_dns_proxy_test.go; the chroot setting was removed by #137 but as the tests were never run we never noticed the failure.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-29484, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

TODO - ensure unit tests are run in CI jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware frobware marked this pull request as draft February 15, 2024 16:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@openshift-ci openshift-ci bot requested review from gcs278 and Miciah February 15, 2024 16:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@frobware frobware force-pushed the OCPBUGS-29484-update-unit-tests branch from 212ad41 to b0b6ca6 Compare February 15, 2024 16:24
@frobware frobware force-pushed the OCPBUGS-29484-update-unit-tests branch from b0b6ca6 to 5575b9d Compare February 15, 2024 16:31
@frobware frobware changed the title [WIP] OCPBUGS-29484: update unit tests in egress/{dns-proxy,http-proxy,router} [WIP] OCPBUGS-29484: update unit tests in egress/dns-proxy Feb 15, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-29484, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The chroot setting was removed by #137.

TODO - ensure unit tests are run in CI jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@frobware frobware changed the title [WIP] OCPBUGS-29484: update unit tests in egress/dns-proxy OCPBUGS-29484: update unit tests in egress/dns-proxy Feb 15, 2024
@openshift-ci openshift-ci bot requested a review from lihongan February 15, 2024 16:33
@frobware frobware marked this pull request as ready for review February 15, 2024 16:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Jira Issue OCPBUGS-29484, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The chroot setting was removed by #137.

TODO - ensure unit tests are run in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 15, 2024

@frobware: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfredette
Copy link
Contributor

/assign

@Miciah
Copy link
Contributor

Miciah commented Mar 6, 2024

/approve
/lgtm
/cherry-pick release-4.15
/cherry-pick release-4.14

@openshift-cherrypick-robot

@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/approve
/lgtm
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@frobware
Copy link
Contributor Author

frobware commented Mar 6, 2024

@bparees Please could you look over this and approve/not approve.

@bparees
Copy link
Contributor

bparees commented Mar 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2266a7f into openshift:master Mar 6, 2024
4 checks passed
@openshift-ci-robot
Copy link
Contributor

@frobware: Jira Issue OCPBUGS-29484: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-29484 has not been moved to the MODIFIED state.

In response to this:

This PR introduces a go.mod file to the top of the tree, enabling the execution of go test. Unit tests are enabled with openshift/release#48854.

It also fixes the unit tests in egress/dns-proxy/egress_dns_proxy_test.go; the chroot setting was removed by #137 but as the tests were never run we never noticed the failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@Miciah: new pull request created: #166

In response to this:

/approve
/lgtm
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Miciah: new pull request created: #167

In response to this:

/approve
/lgtm
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-base-rhel9-container-v4.16.0-202403070215.p0.g2266a7f.assembly.stream.el9 for distgit openshift-enterprise-base-rhel9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants