Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKD-210: Add the sig-nfv repo in the CS9 base #176

Merged
merged 1 commit into from
May 9, 2024

Conversation

aleskandro
Copy link
Member

This PR adds the sig-nfv repositories when CentOS stream is the base image

@openshift-ci openshift-ci bot requested review from rootfs and sjenning May 8, 2024 16:03
@aleskandro
Copy link
Member Author

@aleskandro aleskandro changed the title Add the sig-nfv repo in the CS9 base OKD-210: Add the sig-nfv repo in the CS9 base May 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 8, 2024

@aleskandro: This pull request references OKD-210 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds the sig-nfv repositories when CentOS stream is the base image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aleskandro
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

Copy link
Contributor

openshift-ci bot commented May 8, 2024

@aleskandro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jupierce
Copy link
Contributor

jupierce commented May 9, 2024

As of pull requests like openshift/release#51773 , these base images will be built on top of RHEL (for OCP) and SCOS (for OKD). They are promoted to different imagestreams based on the target platform.
For the root base image, the same Dockerfile is being used, but the introduced logic means that, when being built for OKD, enable additional, non-RHEL repos.

@jupierce
Copy link
Contributor

jupierce commented May 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@jupierce
Copy link
Contributor

jupierce commented May 9, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cea0644 into openshift:master May 9, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-base-rhel9-container-v4.16.0-202405100946.p0.gcea0644.assembly.stream.el9 for distgit openshift-enterprise-base-rhel9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants