-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPCT-220: validation: moving CCSP/validated OCP parts from OPCT docs #17
Conversation
- 'Red Hat Relationship': 'red-hat-relationship/index.md' | ||
- 'Release': 'release/index.md' | ||
- Welcome: index.md | ||
- Full integration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi: this change is aligned with the Platform External documentation, aligned in the change #16
cd6d8fe
to
1818c09
Compare
1818c09
to
c5c8a4f
Compare
3) Run acceptance suite: | ||
|
||
~~~bash | ||
podman run -v ${INSTALL_DIR}:/opt/cluster:Z quay.io/ocsci/ocs-ci-container:stable run-ci -m acceptance --junit-xml /opt/cluster/junit.xml --cluster-path /opt/cluster --ocp-version ${CLUSTER_VERSION} --ocs-version ${CLUSTER_VERSION} --color=yes --cluster-name ${CLUSTER_NAME} tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Email suggestion:
podman run -v ${INSTALL_DIR}:/opt/cluster:Z quay.io/ocsci/ocs-ci-container:stable run-ci -m acceptance --junit-xml /opt/cluster/junit.xml --cluster-path /opt/cluster --ocp-version ${CLUSTER_VERSION} --ocs-version ${CLUSTER_VERSION} --color=yes --cluster-name ${CLUSTER_NAME} tests/ | |
podman run -v ${INSTALL_DIR}:/opt/cluster:Z \ | |
quay.io/ocsci/ocs-ci-container:stable run-ci -m acceptance \ | |
--junit-xml /opt/cluster/junit.xml \ | |
--cluster-path /opt/cluster \ | |
--ocp-version ${CLUSTER_VERSION} \ | |
--ocs-version ${CLUSTER_VERSION} \ | |
--ocsci-conf conf/deployment/baremetal/upi_1az_rhcos_nvme_intel_3m_3w.yaml \ | |
--color=yes \ | |
--cluster-name ${CLUSTER_NAME} tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the location of conf/deployment/baremetal/upi_1az_rhcos_nvme_intel_3m_3w.yaml
based this cmd
$ podman run -v ~/ClusterPath:/opt/cluster:Z quay.io/ocsci/ocs-ci-container:stable run-ci -m acceptance --junit-xml /opt/cluster/junit.xml --cluster-path /opt/cluster --ocp-version 4.13 --ocs-version 4.13 --ocsci-conf conf/deployment/baremetal/upi_1az_rhcos_nvme_intel_3m_3w.yaml --color=yes --cluster-name oviner123 tests/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OdedViner iiuc only the order of the arguments has been changed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.. I tested it on my setup....
/approve |
|
||
~~~bash | ||
oc adm must-gather --image=registry.redhat.io/odf4/odf-must-gather-rhel9 | ||
~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MG cmd failed with this image
$ oc adm must-gather --image=registry.redhat.io/odf4/odf-must-gather-rhel9
[must-gather ] OUT Using must-gather plug-in image: registry.redhat.io/odf4/odf-must-gather-rhel9
When opening a support case, bugzilla, or issue please include the following summary data along with any other requested information:
ClusterID: 90e29e2c-b6bc-42e8-b980-dc7bad925878
ClusterVersion: Stable at "4.13.0-0.nightly-2023-06-19-110814"
ClusterOperators:
clusteroperator/machine-config is degraded because Failed to resync 4.13.0-0.nightly-2023-06-19-110814 because: error during syncRequiredMachineConfigPools: [timed out waiting for the condition, error pool worker is not ready, retrying. Status: (pool degraded: true total: 3, ready 2, updated: 2, unavailable: 0)]
[must-gather ] OUT namespace/openshift-must-gather-nzxg8 created
[must-gather ] OUT clusterrolebinding.rbac.authorization.k8s.io/must-gather-2m9zg created
[must-gather ] OUT pod for plug-in image registry.redhat.io/odf4/odf-must-gather-rhel9 created
[must-gather-9nf66] OUT gather did not start: unable to pull image: ImagePullBackOff: Back-off pulling image "registry.redhat.io/odf4/odf-must-gather-rhel9"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, idk where that image came from :)
I just added the available in the docs https://docs.openshift.com/container-platform/4.10/support/gathering-cluster-data.html
d328f5a
to
e8aa81e
Compare
/assign @rvanderp3 @elmiko |
@mtulio: This pull request references OPCT-220 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mtulio: This pull request references OPCT-220 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtulio, rvanderp3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general this is looking good to me. one thing that bums me out is that apparently we have hit a bug (mkdocs/mkdocs#3111) with mkdocs and our navigation bar.
when i do a fresh load of the page now, i see that the validation guides is highlighted and the focus is moved there. it looks like this:
i'm not sure there is much we can do about it, i've tried messing with the nav bar configuration but we might need to consider flattening the navigation menu or some other way to remediate this.
cb13faf
to
3f383b9
Compare
1a8c0e1
to
4c1ddfa
Compare
This change introduce the /validation path with steps to partners validated the OpenShift installations in non-integrated providers. Those steps are used by CCSP/Validated[1] program, which use the tool OPCT[2] to run conformance tests. Those guides was initialy created in the OPCT tool[3], but it must be moved to a single entry point to partners, leaving the tool to its documentation. [1] https://source.redhat.com/groups/public/global_partner_engagement/global_partner_engagement_wiki/validated_ccsp [2] https://redhat-openshift-ecosystem.github.io/provider-certification-tool/ [3] https://redhat-openshift-ecosystem.github.io/provider-certification-tool/user/
4c1ddfa
to
54eecba
Compare
@mtulio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is on hold awaiting the next steps in the bug mentioned by @elmiko . |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@elmiko: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mtulio: This pull request references OPCT-220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
i think we want to keep working on this, it's just lower priority at the moment. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Closing this PR as we dont have intention and well-defined the model to move on the VCSP guidance. When the card OPCT-220 will be addressed we can revisit this PR. |
This PR introduces a new section
/validation
on Infra Onboarding Guide moving the VCSP/CCSP specific from OPCT documentation, creating more flexibility and details for the types of validation offered by VCSP using OPCT.In the future that "dedicated Guides" will be more critical as OPCT is delivering a lot of features specific to the Program that will require steps to prepare the environment for each one, like SNO, Compact, and Upgrade Disconnected.
The documentation on this website will focus on the validation tests, not the tool itself.
Sections added:
Note:
pymdownx
to allow to include of snippets and reuse markdown fragments of the documentation, creating complete guides reusing existing content.