Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1291: fix/menu: reorder platform external section in the nav bar #23

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Dec 7, 2023

Reordering the Platform External integration to go first in the left nav menu.
fixes #21

/assign @elmiko

@openshift-ci openshift-ci bot requested review from nrb and vincepri December 7, 2023 20:14
@mtulio mtulio changed the title #21 reorder platform external fix/menu: reorder platform external section in the nav bar Dec 7, 2023
@mtulio mtulio changed the title fix/menu: reorder platform external section in the nav bar SPLAT-1291: fix/menu: reorder platform external section in the nav bar Dec 7, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023

@mtulio: This pull request references SPLAT-1291 which is a valid jira issue.

In response to this:

Reordering the Platform External integration to go first in the left nav menu.
fixes #21

/assign @elmiko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Marco!
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, mtulio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit a191840 into openshift:main Dec 12, 2023
2 checks passed
@mtulio mtulio deleted the issue-21-reorder-mkdocs branch December 12, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make platform external the first integration
3 participants