Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDN-3979: E2E extend testing by including disruption test cases #354

Merged
merged 2 commits into from
May 29, 2023
Merged

SDN-3979: E2E extend testing by including disruption test cases #354

merged 2 commits into from
May 29, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented May 27, 2023 •
edited
Loading

- What this PR does and why is it needed
this is follow up to PR #221

test on kind cluster e2e pass

make test-e2e
JUnit report was created: /tmp/test_e2e_logs/e2e_junit.xml

Ran 22 of 22 Specs in 596.378 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped

You're using deprecated Ginkgo functionality

@msherif1234
Add finalizer to nodeState controller to make sure it get deleted whe…
44a0044 
…n node is deletes

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci openshift-ci bot requested review from danwinship and tssurya May 27, 2023 13:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2023
@msherif1234 msherif1234 mentioned this pull request May 27, 2023
Closed
@msherif1234 msherif1234 changed the title Advanced e2e SDN-3979: E2E extend testing by including disruption test cases May 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2023 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references SDN-3979 which is a valid jira issue.

In response to this:

- What this PR does and why is it needed
this is follow up to PR #221

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 force-pushed the advanced_e2e branch 3 times, most recently from 37ed3c0 to 604e568 Compare May 27, 2023 20:06
@msherif1234
Copy link
Contributor Author

/test unit-test

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2023 •
edited by openshift-ci bot
Loading

@msherif1234: This pull request references SDN-3979 which is a valid jira issue.

In response to this:

- What this PR does and why is it needed
this is follow up to PR #221

test on kind cluster e2e pass

make test-e2e
JUnit report was created: /tmp/test_e2e_logs/e2e_junit.xml

Ran 22 of 22 Specs in 596.378 seconds
SUCCESS! -- 22 Passed | 0 Failed | 0 Pending | 0 Skipped

You're using deprecated Ginkgo functionality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/retest

1 similar comment
@msherif1234
Copy link
Contributor Author

/retest

@msherif1234 msherif1234 force-pushed the advanced_e2e branch 2 times, most recently from 32e6c84 to 1f973a4 Compare May 28, 2023 11:13
@msherif1234
Copy link
Contributor Author

/retest

1 similar comment
@msherif1234
Copy link
Contributor Author

/retest

@msherif1234 msherif1234 force-pushed the advanced_e2e branch 4 times, most recently from 531b7d2 to 0ed6340 Compare May 29, 2023 10:45
@msherif1234
Copy link
Contributor Author

/retest

@msherif1234
SDN-3979: adding disruption e2e coverage
601efda 
This is continuation of
github.com/openshift/pull/221

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2023

@msherif1234: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msherif1234 msherif1234 merged commit 9ced0bb into openshift:master May 29, 2023
@msherif1234 msherif1234 deleted the advanced_e2e branch May 30, 2023 14:36
@msherif1234 msherif1234 mentioned this pull request Jun 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@tssurya tssurya Awaiting requested review from tssurya

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msherif1234 @openshift-ci-robot